Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues pointed out by CodeQL #22

Merged
merged 7 commits into from Oct 3, 2020
Merged

Conversation

@LordAro
Copy link
Member

@LordAro LordAro commented Oct 3, 2020

I think that's most of them. PRing so I can see if there's anything left.

I've marked everything in bottle.py as "won't fix". I'd suggest that I'd report them upstream, but nah.

webtranslate/__main__.py Outdated Show resolved Hide resolved
@LordAro LordAro force-pushed the LordAro:codeimprove branch from c521c87 to 7ec1881 Oct 3, 2020
scripts/lang_sync Outdated Show resolved Hide resolved
@LordAro LordAro force-pushed the LordAro:codeimprove branch from 7ec1881 to 5dec361 Oct 3, 2020
@LordAro LordAro force-pushed the LordAro:codeimprove branch from 5dec361 to 0851c37 Oct 3, 2020
@LordAro LordAro force-pushed the LordAro:codeimprove branch from 0851c37 to 9505bdf Oct 3, 2020
Copy link
Member

@TrueBrain TrueBrain left a comment

LGTM

@LordAro LordAro merged commit ad65941 into OpenTTD:master Oct 3, 2020
6 checks passed
6 checks passed
Commit checker
Details
Security and Quality
Details
Docker build
Details
Flake8
Details
Black
Details
CodeQL 44 fixes
Details
@LordAro LordAro deleted the LordAro:codeimprove branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants