Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error checking when uploading translations #41

Merged
merged 2 commits into from May 4, 2021

Conversation

@frosch123
Copy link
Member

@frosch123 frosch123 commented Apr 10, 2021

Fixes

  • When uploading files that exceeded the upload size limit, eints would truncate them, and try to process the rest anyway. (very weird)
  • Truncation could result in invalid utf-8 sequences, resulting in status 500.
  • The upload script considered uploads successful, when eints redirected to a user-friendly pages listing the problems.
frosch123 added 2 commits Apr 10, 2021
…tirely instead of processing some truncated file.
… 4xx status. In most cases eints redirects to a summary page with status 2xx.
@LordAro LordAro merged commit 125570b into OpenTTD:master May 4, 2021
6 checks passed
6 checks passed
@github-actions
Commit checker
Details
@github-actions
Security and Quality Security and Quality
Details
@github-actions
Docker build
Details
@github-actions
Flake8
Details
@github-actions
Black
Details
@github-code-scanning
CodeQL No new or fixed alerts
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants