Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #49: include EINTS manual in the Docker image #50

merged 3 commits into from Sep 29, 2021


Copy link

@glx22 glx22 commented Sep 29, 2021

Links to documentation points to (and it's currently down).
As the documentation is generated from eints repo, I think it's a good idea to include it in the image and stop relying on an external location.

RUN make -C /docs && \
mv /docs/manual/_build/html /code/static/docs && \
rm -r /docs

Copy link

@TrueBrain TrueBrain Sep 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we do a multi stage Dockerfile so we don't get make in the final image.

Check website's Dockerfile if you wonder how that works.


@glx22 glx22 merged commit 20de6ff into OpenTTD:master Sep 29, 2021
7 checks passed
@glx22 glx22 deleted the docs branch Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants