Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: admin links from public pages #56

Merged
merged 1 commit into from Sep 30, 2021
Merged

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Sep 30, 2021

If you are admin, you know those links. They are not useful for anyone else.
Owh, and please don't run eints where you are allowed to just create
projects and languages, that is not secure.

@TrueBrain TrueBrain force-pushed the improvements branch 3 times, most recently from 68c3a00 to cee0166 Sep 30, 2021
@frosch123
Copy link
Member

@frosch123 frosch123 commented Sep 30, 2021

This PR does two things:

  • Hide some buttons in the interface.
  • Deny using the actions associated to them.

The latter is not useful:

  • Those actions are actually needed for maintainance, when renaming projects etc. as admin.
  • Validity of the actions are checked via permissions, so only admin can do it.

Loading

If you are admin, you know those links. They are not useful for anyone else.
Owh, and please don't run eints where you are allowed to just create
projects and languages, that is not secure.
@TrueBrain TrueBrain changed the title Add: setting to lock projects/languages, preventing creation and deletion of those Remove: admin links from public pages Sep 30, 2021
@TrueBrain TrueBrain merged commit 080e0b6 into OpenTTD:master Sep 30, 2021
7 checks passed
Loading
@TrueBrain TrueBrain deleted the improvements branch Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants