Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4: error when viewing an unknown server was vague #22

Merged
merged 1 commit into from Jul 2, 2021

Conversation

@erenes
Copy link
Contributor

@erenes erenes commented Apr 10, 2021

This solves issue #4 and now shows a message "Unknown server" if the master server api returns a 400 error and the first path element in the url is 'server':
image

Because all api calls go through this one method, this was the only place I could detect the error and put the new error message without rearchitecting a bunch. Given my lack of python skills I don't think that would have gone over quite well ;-)

@TrueBrain TrueBrain merged commit 84343d0 into OpenTTD:master Jul 2, 2021
6 checks passed
Loading
@TrueBrain TrueBrain changed the title Fix #4: Unknown server error message Fix #4: error when viewing an unknown server was vague Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants