Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several bugs found while bringing this to production #5

Merged
merged 3 commits into from Sep 10, 2020

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Sep 8, 2020

It is currently running on staging, at:

https://servers.staging.openttd.org/

Sometimes it is annoying Python is not lazy in resolving. Owh well,
easy fix ;)
@@ -192,7 +197,7 @@ def servers(filter):
}

servers = _server_list_cache["servers"]
if filter != "all":
if filter is not None:

This comment has been minimized.

@frosch123

frosch123 Sep 9, 2020
Member

Could be just "if filter:".
Unless you want to test startswith("")

Maybe convert "" to None, to make it easier in the template?

@TrueBrain TrueBrain force-pushed the TrueBrain:bugs_in_prod branch from af1e57a to 307fd3c Sep 9, 2020
@TrueBrain TrueBrain merged commit a8bbd0b into OpenTTD:master Sep 10, 2020
4 checks passed
4 checks passed
Docker build
Details
Flake8
Details
Black
Details
LGTM analysis: Python No new or fixed alerts
Details
@TrueBrain TrueBrain deleted the TrueBrain:bugs_in_prod branch Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.