Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several bugs found while bringing this to production #4

Merged
merged 4 commits into from Sep 10, 2020

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Sep 8, 2020

See individual commits to find out what is being fixed.

TrueBrain added 4 commits Sep 7, 2020
This helps in deployments to AWS to know if the server is done
starting up.
aiohttp has this odd thing that it closes down the event-loop it
is running in. This includes the transports. So by the time we exit
from the run() function, those transports are already long gone.
Turns out, only the first package of a stream contains the proxy
protocol header when using nginx. So we need to track the mapping.
@TrueBrain TrueBrain force-pushed the TrueBrain:bugs_in_prod branch from e9b7c69 to 005c756 Sep 8, 2020
@TrueBrain TrueBrain merged commit 2264a2a into OpenTTD:master Sep 10, 2020
5 checks passed
5 checks passed
Docker build
Details
Flake8
Details
Black
Details
pytest
Details
LGTM analysis: Python No new or fixed alerts
Details
@TrueBrain TrueBrain deleted the TrueBrain:bugs_in_prod branch Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.