Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is Pillow >= 5.2 required? #58

Closed
matthijskooijman opened this issue Nov 17, 2019 · 3 comments
Closed

Why is Pillow >= 5.2 required? #58

matthijskooijman opened this issue Nov 17, 2019 · 3 comments

Comments

@matthijskooijman
Copy link
Contributor

@matthijskooijman matthijskooijman commented Nov 17, 2019

Since #29, the README documents a minimum required Pillow version of 5.2. However, running some tests with version 3.4 seems to work just fine?

To test, I modified setup.py to remove the version constraint, then downgraded Pillow using pip install Pillow=3.4.0. Then I ran the regression tests (make all in the regression directory) and built OpenGFX, both of which completed without apparent problems.

@LordAro, you originally requested to add this constraint, perhaps you can comment?

@LordAro
Copy link
Member

@LordAro LordAro commented Apr 20, 2020

No real reason as best as I can tell. I think my comment was based on the assumption that PILLOW_VERSION was only added in 5.2, which it doesn't look like is the case. Certainly not the case now that __version__ is used, anyway

LordAro added a commit to LordAro/nml that referenced this issue Apr 20, 2020
@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Apr 20, 2020

So shall I edit the README to 3.4?

I'm not going on a bisection mission to find the lowest compatible version, but I am happy to edit README to say 3.4

FWIW, I'm on Pillow 7.0.0, but that's neither here nor there :P

[edit] NVM I was too slow :) #95

@matthijskooijman
Copy link
Contributor Author

@matthijskooijman matthijskooijman commented Apr 21, 2020

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.