Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude version update code (fixes #112) and dotfiles from release tarballs. #136

Merged
merged 3 commits into from May 10, 2020

Conversation

@FLHerne
Copy link
Contributor

@FLHerne FLHerne commented May 10, 2020

Closes #115

It's been a while since nml was in Mercurial...
@FLHerne FLHerne force-pushed the flh-release-version branch from c1f7ea3 to daa9a20 May 10, 2020
@FLHerne FLHerne changed the title Fix #112: Remove version updating from release tarballs. Exclude version update code (fixes #112) and dotfiles from release tarballs. May 10, 2020
setup.py Show resolved Hide resolved
This excludes .dorpsgek.yml, .gitignore and .github/ from the tarballs.
@FLHerne FLHerne force-pushed the flh-release-version branch 2 times, most recently from b2bdbe0 to 6ffde4e May 10, 2020
@FLHerne FLHerne force-pushed the flh-release-version branch from 6ffde4e to 146f624 May 10, 2020
@FLHerne FLHerne merged commit 396b64b into OpenTTD:master May 10, 2020
16 checks passed
@matthijskooijman
Copy link
Contributor

@matthijskooijman matthijskooijman commented May 11, 2020

I'm a bit late to the party, but these changes look good to me! Given setuptools_scm wasn't a clear all-in-one solution, it could have been used just as as library to parse git tags (and maybe PKG_INFO files), but since we already had code for that, probably better to not add one more dependency. Thanks for working on this!

@FLHerne FLHerne deleted the flh-release-version branch Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants