Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #139: Make --cache-dir work and don't create a directory when --no-cache is given. #142

Closed
wants to merge 2 commits into from

Conversation

FLHerne
Copy link
Contributor

@FLHerne FLHerne commented May 12, 2020

No description provided.

@frosch123
Copy link
Member

frosch123 commented May 13, 2020

The original intention was that more stuff gets cached (like parser trees). But none of the attempts ever resulted in a speed-up.

However, that's why the cache-dir stuff is in generic.py, and not in spritechache.py.

@FLHerne
Copy link
Contributor Author

FLHerne commented May 14, 2020

My feeling is that the code can always be made 'generic' if and when there's another real use-case for it, and that doing so pre-emptively makes it harder to follow.

If you feel strongly the other way I can change it back, but would rather not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants