Add: Support for parameters in switches #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's rebased on top of #156 for easier testing |
|
Works for me in Iron Horse. |
glx22
force-pushed
the
switch_param
branch
2 times, most recently
from
0ecc64c
to
6816a40
Compare
LordAro
requested changes
Jul 5, 2020
FLHerne
requested changes
Aug 25, 2020
Reviewed code-wise. I haven't yet tried to figure out whether the resulting NFO makes sense.
FLHerne
reviewed
Aug 29, 2020
| store_tmp = VarAction2StoreCallParam(target.register_map[self.feature][i]) | ||
| self.parse_expr(reduce_varaction2_expr(param, self.feature)) | ||
| self.var_list.append(nmlop.STO_TMP) | ||
| self.var_list.append(store_tmp) |
There was a problem hiding this comment.
This could be self.var_list += (nmlop.STO_TMP, store_tmp), and similarly below. Current way might be clearer, not sure.
FLHerne
previously approved these changes
Aug 29, 2020
LordAro
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
New syntax, compatible with old one: