Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove trailing whitespaces in NFO output #164

Merged
merged 1 commit into from Oct 3, 2020

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Oct 2, 2020

Commit checker should now be happy.

@glx22 glx22 changed the title Fix: Remove trailing whitespaces in output Fix: Remove trailing whitespaces in NFO output Oct 3, 2020
@glx22 glx22 force-pushed the glx22:whitespaces branch from c18a4a8 to a224bcd Oct 3, 2020
@LordAro
Copy link
Member

@LordAro LordAro commented Oct 3, 2020

It's a bit odd that it's always a single space for every single line.. why is it there in the first place?

@glx22
Copy link
Contributor Author

@glx22 glx22 commented Oct 3, 2020

It's there because all writes add it, as it's simpler to always add a space in case there's something written after.

@LordAro
Copy link
Member

@LordAro LordAro commented Oct 3, 2020

Add a comment so it's obvious that's the reason?

@glx22 glx22 force-pushed the glx22:whitespaces branch from a224bcd to 960651a Oct 3, 2020
@LordAro
LordAro approved these changes Oct 3, 2020
@LordAro LordAro merged commit 49c5d50 into OpenTTD:master Oct 3, 2020
19 checks passed
19 checks passed
Commit checker
Details
Python 3.5 on ubuntu-latest
Details
Security and Quality
Details
Python 3.6 on ubuntu-latest
Details
Python 3.7 on ubuntu-latest
Details
Python 3.8 on ubuntu-latest
Details
Python pypy3 on ubuntu-latest
Details
Python 3.5 on macOS-latest
Details
Python 3.6 on macOS-latest
Details
Python 3.7 on macOS-latest
Details
Python 3.8 on macOS-latest
Details
Python 3.5 on windows-2016
Details
Python 3.6 on windows-2016
Details
Python 3.7 on windows-2016
Details
Python 3.8 on windows-2016
Details
Python 3.x on ubuntu-latest
Details
Python 3.x on macOS-latest
Details
Python 3.x on windows-2016
Details
CodeQL No new alerts
Details
@glx22 glx22 deleted the glx22:whitespaces branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants