Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #180: No proper error message was given, if an unreferenced Strin… #181

Merged
merged 1 commit into from Jan 21, 2021

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Jan 6, 2021

…g was unable to allocate an id

@FLHerne
Copy link
Contributor

@FLHerne FLHerne commented Jan 6, 2021

The error message still isn't very user-friendly, it doesn't explain that the failure is due to hitting a limit nor what that limit is.

Something like the one for items would be better: "Unable to allocate ID for string, no more free IDs available (maximum is {:d})" ?

The regression-test failure is odd and seems unrelated to this change?

@glx22
Copy link
Contributor Author

@glx22 glx22 commented Jan 6, 2021

Regression failure is caused by newer version of pillow.
And I agree, I'll update the message.

@glx22 glx22 force-pushed the glx22:string_id branch from bdc340c to c6f81cf Jan 6, 2021
Copy link
Member

@LordAro LordAro left a comment

LGTM

…g was unable to allocate an id
@glx22 glx22 force-pushed the glx22:string_id branch from c6f81cf to a0958ad Jan 21, 2021
@glx22 glx22 merged commit 3ea1d89 into OpenTTD:master Jan 21, 2021
21 checks passed
21 checks passed
Commit checker
Details
Python 3.5 on ubuntu-latest
Details
Security and Quality Security and Quality
Details
Python 3.6 on ubuntu-latest
Details
Python 3.7 on ubuntu-latest
Details
Python 3.8 on ubuntu-latest
Details
Python pypy3 on ubuntu-latest
Details
Python 3.5 on macOS-latest
Details
Python 3.6 on macOS-latest
Details
Python 3.7 on macOS-latest
Details
Python 3.8 on macOS-latest
Details
Python 3.5 on windows-2016
Details
Python 3.6 on windows-2016
Details
Python 3.7 on windows-2016
Details
Python 3.8 on windows-2016
Details
Python 3.x on ubuntu-latest
Details
Python 3.x on macOS-latest
Details
Python 3.x on windows-2016
Details
Flake8
Details
Black
Details
CodeQL No new alerts
Details
@glx22 glx22 deleted the glx22:string_id branch Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants