Fix #180: No proper error message was given, if an unreferenced Strin… #181
Conversation
|
The error message still isn't very user-friendly, it doesn't explain that the failure is due to hitting a limit nor what that limit is. Something like the one for items would be better: "Unable to allocate ID for string, no more free IDs available (maximum is {:d})" ? The regression-test failure is odd and seems unrelated to this change? |
|
Regression failure is caused by newer version of pillow. |
|
LGTM |
…g was unable to allocate an id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
…g was unable to allocate an id