Fix #209: Sign-extend value before cargo_profit callback result calculation #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
NML does apply some calculation before returning the cargo_profit callback result.
But it does it on a 15bit signed value stored in 32bit without sign-extending, so of course the result for negative is wrong.
It's fixed in this PR by applying sign-extension to the 15bit value before doing other calculation.
Of course another option would be to just remove all this strange magical stuff ;)