Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use a most likely defined position when reporting error #226

Merged
merged 1 commit into from Jul 17, 2021

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Jul 17, 2021

Errors without the corresponding line number are not very useful.

action2var.parse_variable() uses position of number or register when reporting an error, but they usually are not set. So it's better to use the position of the expression itself.

@glx22 glx22 merged commit 60cb27d into OpenTTD:master Jul 17, 2021
21 checks passed
Loading
@glx22 glx22 deleted the error branch Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants