Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Options to disable optimisation and/or deprecation warnings #230

Merged
merged 1 commit into from Aug 15, 2021

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Aug 7, 2021

This allows to silence some annoying warnings.

@LordAro
Copy link
Member

@LordAro LordAro commented Aug 7, 2021

👍 Though can't help but feel like having the type parameter last is a bit weird, and easily missed. But obviously putting it first is infeasible at this point (I imagine there are a lot of warning messages) Perhaps a few helper functions?

Loading

@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Aug 7, 2021

--no-optimisation-warning works for me with FIRS

Loading

@glx22
Copy link
Contributor Author

@glx22 glx22 commented Aug 7, 2021

👍 Though can't help but feel like having the type parameter last is a bit weird, and easily missed. But obviously putting it first is infeasible at this point (I imagine there are a lot of warning messages) Perhaps a few helper functions?

Well, there are 40 references of print_warning, so it should not be too hard to add type as first parameter.

Loading

@glx22 glx22 merged commit b8ca217 into OpenTTD:master Aug 15, 2021
21 checks passed
Loading
@glx22 glx22 deleted the warnings branch Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants