Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #240: Incomplete read only checks #242

Merged
merged 3 commits into from Oct 10, 2021
Merged

Fix #240: Incomplete read only checks #242

merged 3 commits into from Oct 10, 2021

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Oct 10, 2021

If any of the fixes is missing, ternary_optimisation is replaced on the fly with return 5; and proc_call_optimisation is ignored.

@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Oct 10, 2021

Works for me with FIRS test case.

Code looks fine, not that my reviewing abilities are the best.

Loading

Copy link
Member

@LordAro LordAro left a comment

Seems fine, though I predict the issue recurring in future. Would be "nice"(?) to do some magic and automatically test all class members that have the is_read_only method attached to them

Loading

@glx22 glx22 merged commit bd6b34e into OpenTTD:master Oct 10, 2021
21 checks passed
Loading
@glx22 glx22 deleted the read_only branch Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants