Fix: Allow access to towns as parent object #28
Closed
Conversation
|
I think that separate PR should happen before this, to be honest. |
|
Alternative solution:
|
|
Since checks are enabled, a rebase to master is required to include workflow file. |
| varact2vars60x = 0x13 * [{}] | ||
| # feature number: 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B, 0x0C, 0x0D, 0x0E, 0x0F, 0x10, 0x11, 0x12 | ||
| varact2parent_scope = [0x00, 0x01, 0x02, 0x03, 0x12, None, 0x12, 0x12, None, 0x0A, 0x12, None, None, None, None, 0x12, None, None, None] | ||
| from nml.ast.general import feature_ids as feature |
glx22
May 15, 2020
Contributor
It's feature here but fids in other files.
It's feature here but fids in other files.
|
No change in a while. Gonna close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
So it needs some generic featureID used as parent.
Generally the features probably should be referenced via a symbolic name than their numeric ID in the code or this will fall onto our feet when a new feature is introduced. But that is a separate PR outside the scope of this.
And... I don't understand why this is not an update to the existing PR. Stupid github #26