Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow access to towns as parent object #28

Closed
wants to merge 2 commits into from

Conversation

@planetmaker
Copy link
Contributor

@planetmaker planetmaker commented Apr 9, 2019

So it needs some generic featureID used as parent.

Generally the features probably should be referenced via a symbolic name than their numeric ID in the code or this will fall onto our feet when a new feature is introduced. But that is a separate PR outside the scope of this.

And... I don't understand why this is not an update to the existing PR. Stupid github #26

@PeterN
Copy link
Member

@PeterN PeterN commented Apr 9, 2019

I think that separate PR should happen before this, to be honest.

@frosch123
Copy link
Member

@frosch123 frosch123 commented Apr 9, 2019

Alternative solution:
https://gist.github.com/frosch123/fb62db8e6a65c0de1614ad1f663f1827

  • It uses a text instead of a (wrong) number.
  • Towns are accepted by feature_name, but not by parse_feature.
  • Removes the references to feature 8, which were likely means to be "towns".
@glx22
Copy link
Contributor

@glx22 glx22 commented Nov 24, 2019

Since checks are enabled, a rebase to master is required to include workflow file.

varact2vars60x = 0x13 * [{}]
# feature number: 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B, 0x0C, 0x0D, 0x0E, 0x0F, 0x10, 0x11, 0x12
varact2parent_scope = [0x00, 0x01, 0x02, 0x03, 0x12, None, 0x12, 0x12, None, 0x0A, 0x12, None, None, None, None, 0x12, None, None, None]
from nml.ast.general import feature_ids as feature

This comment has been minimized.

@glx22

glx22 May 15, 2020
Contributor

It's feature here but fids in other files.

@LordAro
Copy link
Member

@LordAro LordAro commented Oct 3, 2020

No change in a while. Gonna close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants