Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with >=pillow-6.0.0 #29

Merged
merged 1 commit into from Jun 3, 2019
Merged

Conversation

@ConiKost
Copy link
Contributor

ConiKost commented Apr 18, 2019

Changed VERSION to PILLOW_VERSION,
as it got removed with >=pillow-6.0.0.

Signed-off-by: Conrad Kostecki conrad@kostecki.com

@LordAro

This comment has been minimized.

Copy link
Member

LordAro commented Apr 18, 2019

Maybe also a note to say minimal Pillow version is now 5.2 ?

@ConiKost

This comment has been minimized.

Copy link
Contributor Author

ConiKost commented Apr 18, 2019

As a addition to the not found message?

@LordAro

This comment has been minimized.

Copy link
Member

LordAro commented Apr 18, 2019

I mean in the readme :)

ConiKost added a commit to ConiKost/gentoo that referenced this pull request Apr 18, 2019
Patch submitted upstream: OpenTTD/nml#29

Package-Manager: Portage-2.3.63, Repoman-2.3.12
Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
ConiKost added a commit to ConiKost/gentoo that referenced this pull request Apr 18, 2019
Patch submitted upstream: OpenTTD/nml#29

Package-Manager: Portage-2.3.63, Repoman-2.3.12
Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
Changed VERSION to PILLOW_VERSION,
as it got removed with >=pillow-6.0.0.

Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
@ConiKost

This comment has been minimized.

Copy link
Contributor Author

ConiKost commented Apr 18, 2019

Done.

gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Apr 18, 2019
Patch submitted upstream: OpenTTD/nml#29

Package-Manager: Portage-2.3.63, Repoman-2.3.12
Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
Closes: #11734
Signed-off-by: James Le Cuirot <chewi@gentoo.org>
@LordAro
LordAro approved these changes Jun 3, 2019
@LordAro LordAro merged commit bcfff83 into OpenTTD:master Jun 3, 2019
@matthijskooijman

This comment has been minimized.

Copy link
Contributor

matthijskooijman commented Oct 21, 2019

Apparently PILLOW_VERSION is also deprecated and PIL.__version__ should be used instead? See https://pillow.readthedocs.io/en/5.2.x/releasenotes/5.2.0.html#id1

@LordAro

This comment has been minimized.

Copy link
Member

LordAro commented Oct 21, 2019

Ha. Will reopen the original issue

matthijskooijman added a commit to matthijskooijman/nml that referenced this pull request Nov 17, 2019
Previously, this tried various combinations of version variables.
However, some of these are deprecated by Pillow and the 6.0.0 release
notes recommend simply using `PIL.__version` instead. This attribute is
available since Pillow 3.4.0, so there is no need for any compatibility
fallbacks.

This relates to OpenTTD#29, OpenTTD#39 and OpenTTD#54.
matthijskooijman added a commit to matthijskooijman/nml that referenced this pull request Nov 29, 2019
Previously, this tried various combinations of version variables.
However, some of these are deprecated by Pillow and the 6.0.0 release
notes recommend simply using `PIL.__version` instead. This attribute is
available since Pillow 3.4.0, so there is no need for any compatibility
fallbacks.

This relates to OpenTTD#29, OpenTTD#39 and OpenTTD#54.
LordAro added a commit that referenced this pull request Nov 29, 2019
Previously, this tried various combinations of version variables.
However, some of these are deprecated by Pillow and the 6.0.0 release
notes recommend simply using `PIL.__version` instead. This attribute is
available since Pillow 3.4.0, so there is no need for any compatibility
fallbacks.

This relates to #29, #39 and #54.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.