Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ottd_display_speed to reflect changes done in OpenTTD #34

Closed
wants to merge 30 commits into from

Conversation

@juzza1
Copy link

juzza1 commented May 1, 2019

736f034 fixed rounding errors with nml->nfo conversion, however the ottd_display_speed function has not been updated to reflect changes done in OpenTTD/OpenTTD@7634416. Specifically, the display value should be divided only after all other conversions have been done. The updated version of the function fixes the many off-by-one rounding errors currently present with nml coded vehicles.

planetmaker and others added 30 commits Oct 23, 2018
* Change: Adopt the versioning scheme as OpenTTD does uses now with git

* Fail gracefully when operating on detached head
Change: Build and publish on DevZone appropriately from git source
* Doc: add simple cargo wagon to example train nml

* Docs: example cargo wagon nml now uses sprite stack to add cargo to base wagon

* Docs: add comments to sprite stack example for trains
…rs (#8)

I didn't rebase this into previous examples commit.
Docs: update README
…types (#13)

in Openttd bf8d7df7367055dcfad6cc1c21fd9c762ffc2fe4
* Fix: Don't warn on missing files which are allowed to be missing during build

* Change: Consider origin/master a useful revision
…ion2. (#24)

If using a random_switch for an industry tile when the choice is based on its "related" object, an exception is thrown.
* Codechange: Rename CargotypeListProp to ByteListProp since it's sufficiently generic

* Add: Flag 18 for industries

* Add: Industry props 25 26 support

* Add: Industry prop 27 support

* Add: Industry prop 28

* Add: Industry tile special flag 1

* Docs: add an example industry, using the new 16-in, 16-out props (incomplete)

* Add: Support for industries property 28 (input_multiplier)

* Add: New 0x69-0x6F variables for industries

* Doc: Explain input_multiplier (prop 28) better in example industry

* Fix: Properly accept floats for industry input_multipliers

* Docs: add cargotable to example industry, and use in accept/produce props

* Docs: stub in extra_text_industry at example factory industry (non-functional)

* Add: New combined cargo_types property for industry definitions

* Remove: Take away support in old NML properties for new industry properties

* Docs: adjust example of how to use text stack in extra_text_industry to simple single var check

* Codechange: Two slightly different classes had the same name, rename one

* Change: Make the accept_cargo/produce_cargo expressions a little more regular

* Add: WIP prod cb v2 support

* Add: Support for production callback v2

* Remove: Old industry production/acceptance syntax

* Remove: Support for old produce syntax

* Remove: Deprecated industry variables
The number of GUI sprites has increased since the group liveries addition (OpenTTD/OpenTTD#7108).
@juzza1 juzza1 closed this May 1, 2019
@juzza1 juzza1 deleted the juzza1:speed_fixes branch May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
You can’t perform that action at this time.