Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ottd_display_speed to reflect changes done in OpenTTD #35

Open
wants to merge 1 commit into
base: master
from

Conversation

@juzza1
Copy link

juzza1 commented May 1, 2019

736f034 fixed rounding errors with nml->nfo conversion, however the ottd_display_speed function has not been updated to reflect changes done in OpenTTD/OpenTTD@7634416. Specifically, the display value should be divided only after all other conversions have been done. The updated version of the function fixes the many off-by-one rounding errors currently present with nml coded vehicles.

@LordAro LordAro requested a review from frosch123 Jun 3, 2019
@glx22

This comment has been minimized.

Copy link
Contributor

glx22 commented Nov 24, 2019

Since checks are enabled, a rebase to master is required to include workflow file.

Copy link
Contributor

planetmaker left a comment

Wouldn't some of the regression tests need an update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.