Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: use pyinstaller to generate standalone executable (and other mostly windows related changes) #55

Merged
merged 6 commits into from Nov 9, 2019

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Nov 7, 2019

cx_Freeze was not working correctly, nml_lz77 lib was built and included but not used.
pyinstaller includes and uses the lib, as long as it's next to nmlc, this is enforced in nmlc.spec.
python ./setup.py install was not really usable on windows, as it copied nmlc directly, now setuptools will generate a wrapper executable, as it did before 78cd84c.
The batch file just builds the lib at the right place then creates the standalone exe in dist.

LordAro
LordAro approved these changes Nov 7, 2019
Copy link
Member

@LordAro LordAro left a comment

setup.py changes LGTM (otherwise untested)

@glx22
Copy link
Contributor Author

@glx22 glx22 commented Nov 7, 2019

Some generated executables, using different python version, are available as artifacts here

@glx22
Copy link
Contributor Author

@glx22 glx22 commented Nov 8, 2019

Hmm just thinking, but maybe it would be nice to set install_requires in setup.py.

@glx22 glx22 changed the title Codechange: use pyinstaller to generate standalone executable Codechange: use pyinstaller to generate standalone executable (and other mostly windows related changes) Nov 9, 2019
@LordAro LordAro merged commit abb7a3a into OpenTTD:master Nov 9, 2019
@glx22 glx22 deleted the pyinstaller branch Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants