Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanical cleanups #62

Merged
merged 2 commits into from Nov 20, 2019
Merged

Mechanical cleanups #62

merged 2 commits into from Nov 20, 2019

Conversation

@FLHerne
Copy link
Contributor

FLHerne commented Nov 20, 2019

A couple of trivial search-and-replace cleanups that should have no functional changes.

Tests pass.

FLHerne added 2 commits Nov 20, 2019
This is redundant in Python 3, and py2 is no longer supported.
No functional changes.

Generated using:
`find . -name '*.py' -print0 | xargs -0 sed -i 's/(object):/:/'`
In all cases:
 * The original type is one of
    `dict`, `dict_items`, `dict_keys` or `dict_values`.
 * The list is either iterated over or used to test `x in list`, then
    discarded.

These operations work identically on the original type, so the
 conversion is pointless.
@andythenorth
Copy link
Contributor

andythenorth commented Nov 20, 2019

Tested locally:

  • builds
  • tests pass
  • sample newgrf compile works
  • diff looks fine, all looks like legacy artefacts
@andythenorth andythenorth merged commit f23cb3b into OpenTTD:master Nov 20, 2019
@FLHerne FLHerne deleted the FLHerne:mechanical-tidying branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.