Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #57: Check coherency of GRF parameters limits #65

Merged
merged 3 commits into from Nov 29, 2019
Merged

Conversation

@glx22
Copy link
Contributor

glx22 commented Nov 23, 2019

Added a uvalue attribute to ConstantNumeric containing unsigned equivalent of value. Using this attribute it's easy to check coherency of min/max. Also used uvalue to ensure the parameter settings are in the uint32 range.

nml/actions/action14.py Outdated Show resolved Hide resolved
nml/actions/action14.py Outdated Show resolved Hide resolved
nml/ast/grf.py Outdated Show resolved Hide resolved
@glx22
Copy link
Contributor Author

glx22 commented Nov 23, 2019

hmm I think I should also check that default value is inside min/max

@glx22 glx22 force-pushed the glx22:fix_57 branch from 3558156 to 7c29fcf Nov 24, 2019
@LordAro LordAro merged commit 10be1f1 into OpenTTD:master Nov 29, 2019
12 checks passed
12 checks passed
Python 3.5 on ubuntu-latest
Details
Python 3.6 on ubuntu-latest
Details
Python 3.7 on ubuntu-latest
Details
Python 3.8 on ubuntu-latest
Details
Python 3.5 on macOS-latest
Details
Python 3.6 on macOS-latest
Details
Python 3.7 on macOS-latest
Details
Python 3.8 on macOS-latest
Details
Python 3.5 on windows-2016
Details
Python 3.6 on windows-2016
Details
Python 3.7 on windows-2016
Details
Python 3.8 on windows-2016
Details
@glx22 glx22 deleted the glx22:fix_57 branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.