Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release workflow #93

Merged
merged 4 commits into from Apr 23, 2020
Merged

Add release workflow #93

merged 4 commits into from Apr 23, 2020

Conversation

@LordAro
Copy link
Member

@LordAro LordAro commented Apr 2, 2020

Not finished yet

  • Build Python wheels for Windows, MacOS & Linux (manylinux2010)
  • Builds standalone (win64) nmlc executable
  • Fixes a bug in git version calculation with tags
  • Make py38 work ( RalfG/python-wheels-manylinux-build#14 )
  • Work out which artefacts want to be distributed with the release (fixes Linux release failure)
  • See if build artefacts can be attached to the release Not worth the bother
  • Remove test code
  • Add PYPI_PASSWORD secrets to repo

Latest release build example: https://github.com/LordAro/nml/actions/runs/83157723

Copy link
Member

@TrueBrain TrueBrain left a comment

quick nitpicking on what I can spot. Can't really validate the flow itself, just the syntax and how GitHub Actions are used :)

.github/workflows/regression.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
nml/version_info.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@MinchinWeb
Copy link

@MinchinWeb MinchinWeb commented Apr 14, 2020

Oooh... does this mean we'll start seeing "regular" PyPI releases?

@LordAro LordAro marked this pull request as ready for review Apr 20, 2020
@LordAro LordAro dismissed TrueBrain’s stale review Apr 20, 2020

out of date

@LordAro LordAro requested a review from TrueBrain Apr 20, 2020
Copy link
Member

@TrueBrain TrueBrain left a comment

minor comments; LGTM, but I cannot judge the context. But I am sure you either tested it, or this merge will test it :D

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/testing.yml Outdated Show resolved Hide resolved
Copy link
Member

@TrueBrain TrueBrain left a comment

LGTM .. for what-ever that is worth :)

@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Apr 21, 2020

Merging, as TB has approved.

@andythenorth andythenorth merged commit 524231a into OpenTTD:master Apr 23, 2020
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants