Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many hardcoded URLs #25

Closed
TrueBrain opened this issue Jan 19, 2019 · 4 comments
Closed

Many hardcoded URLs #25

TrueBrain opened this issue Jan 19, 2019 · 4 comments
Labels
Milestone

Comments

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 19, 2019

On several places we have URLs to places like binaries.openttd.org, proxy.binaries.openttd.org, READMEs, Changelogs, etc. This is a bit difficult to maintain, as there is not a single place to change it. You have to know where to look to change them.

We also have links to 'about.html', and we are not using Jekyll to tell us the URL of that page. This makes changing the URL schema very difficult.

It would be nice to reduce this way of referencing URLs. Please look into this and come up with a proper solution (if possible).

@TrueBrain TrueBrain added this to the 2.0.0 milestone Jan 22, 2019
@claman
Copy link
Contributor

@claman claman commented Jan 23, 2019

so the goal would be to replace them with relative URLs where possible?

@TrueBrain
Copy link
Member Author

@TrueBrain TrueBrain commented Jan 23, 2019

Okay, the ticket was a bit vague. Fixed that now :)

And no, I was not suggesting to make things into relative URLs (in many places we even can't). But hopefully the new description is more clear :D But the ticket in other words: I rather have a single place/variable with a reference to an URL, than have it copied 10 times in all sorts of places.

@claman
Copy link
Contributor

@claman claman commented Jan 23, 2019

Aha, gotcha. That's definitely clearer now :)

It's looking the best way will be to use the _data folder: https://jekyllrb.com/docs/datafiles/, since that lets us define custom variables that will be accessible site-wide

This tutorial might also be useful: https://jekyllrb.com/tutorials/navigation/ (not sure, but it seems worth including).

I can take a bit more of a look when I have some free time this weekend.

@TrueBrain
Copy link
Member Author

@TrueBrain TrueBrain commented Dec 7, 2019

I am myself not even sure what this ticket was about. Clearly not a priority :) Closing it up!

@TrueBrain TrueBrain closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.