Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation issues #30

Closed
andythenorth opened this issue Jan 22, 2019 · 3 comments
Closed

Validation issues #30

andythenorth opened this issue Jan 22, 2019 · 3 comments

Comments

@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jan 22, 2019

  1. WAVE toolbar reports 39 contrast errors for the home page, these are primarily in the layout templates, and will be present on most pages.

  2. WAVE toolbar reports accessibility failures on the download pages, primarily form labels missing.

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 22, 2019

@andythenorth : do you plan to tackle these issues yourself? Otherwise you should really add more information about the issues :) This ticket currently is not fixable by anyone.

I have no clue what WAVE is. If WAVE is free to use, a link to this could be sufficient.

Basically: anything more than "something is wrong" would be appreciated :D

@andythenorth
Copy link
Contributor Author

@andythenorth andythenorth commented Jan 22, 2019

I am planning to fix these, but not a priority for me.

If anyone else wants to resolve them:

  • WAVE is a free validation tool from WebAIM https://wave.webaim.org/
  • I use it via the Chrome plugin
  • I run the OpenTTD website locally using jekyll serve, then check one page at a time
  • the contrast checker sometimes gives spurious failures, as it can't always resolve the css hierarchy to work out what the user will actually see rendered, but it's generally a pretty good guide, and I tend to fix the CSS so all the errors are resolved, it's usually not much work.

I also ran W3C html5 validator over the front page of the staging site: https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.staging.openttd.org%2F

This shows a couple of issues that are quite easy to fix.

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 7, 2019

Seems the priority is this low, that it isn't being fixed ;) Going to close the issue now. If anyone wants to send in PRs, they are more than welcome!

@TrueBrain TrueBrain closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.