Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.openttd.org always shows "Login" instead of "Logout (account name)" #96

Closed
James103 opened this issue Aug 2, 2019 · 3 comments
Closed

Comments

@James103
Copy link
Contributor

@James103 James103 commented Aug 2, 2019

Whenever I go to any page in www.openttd.org, the footer says "Login" instead of "Logout (account name". This does not happen elsewhere (tested on bananas.openttd.org, servers.openttd.org, account.openttd.org).
When not on www.openttd.org:
image
When on www.openttd.org:
image

@James103 James103 changed the title www.openttd.org always shows www.openttd.org always shows "Login" instead of "Logout (account name)" Aug 2, 2019
@glx22
Copy link
Contributor

@glx22 glx22 commented Aug 2, 2019

www.openttd.org is fully static and not concerned by login status

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Aug 2, 2019

Just because it quacks like a duck ;)

Although our templates look very similar, it doesn't mean they are the same. As @glx22 mentioned, www.openttd.org is a full static page, where the others are not. Slowly you will see the other pages changing to (semi)static pages too, like servers, etc. Bananas is one of the few that will keep the dynamic behaviour, as, well, it is more appropriate there :D

So this is not a bug. The one thing that does come to mind, that "Login" might be a bit weird as option between there. We could either remove it completely (as only BaNaNaS requires the login these days; and it asks for it when you need to enter it anyway), or change it to something like "Account" or "Manage". If you are up for that, please create a PR to address this (either of the options is fine by me).

Tnx!

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 7, 2019

Seems nobody cares enough to fix this :) Closing the issue. Nevertheless, tnx for the report!

@TrueBrain TrueBrain closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.