Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: semantic HTML-elements for the pages main sections #113

Merged
merged 1 commit into from Dec 27, 2019

Conversation

@auge8472
Copy link
Contributor

auge8472 commented Dec 12, 2019

… and corresponding CSS-rules

Further changes:

  • remove background.png (replaced with CSS background-color)
  • replace class name 'right' with 'further-link' because 'right' is based on the current optical represantation and with a change of that …

This is my third attempt to create an overhauled structure of the main page elements. After waiting for over a half year for the motivation to finish the work in #84 and struggling with importing the changes of the last seven months I decided to cherry-pick the old changes into a new branch and to finish the work on the requested change. I hope, these are all necessary parts.

@auge8472
Copy link
Contributor Author

auge8472 commented Dec 17, 2019

Building the website failed in the test because of an error, thrown in fetch-downloads.py (returned a non-zero code: 1). I didn't touch fetch-downloads.py and don't know how to handle the error. Any advice?

@glx22
Copy link
Contributor

glx22 commented Dec 17, 2019

It's the usual random failure of downloads

@glx22
Copy link
Contributor

glx22 commented Dec 17, 2019

Oh nice now the farm is totally broken. Seems to be a ruby update from yesterday.

@TrueBrain
Copy link
Member

TrueBrain commented Dec 17, 2019

Please rebase; that should fix the checks :)

@auge8472
Copy link
Contributor Author

auge8472 commented Dec 18, 2019

Please rebase; that should fix the checks :)

You mean I should rebase my branch including your change of #114 following i.e. these instructions? Is that correct?

@LordAro
Copy link
Member

LordAro commented Dec 18, 2019

That would have the effect of retriggering the CI, yes

…ding CSS-rules

Further changes:

- remove background.png (replaced with CSS background-color)
- replace class name 'right' with 'further-link' because 'right' is based on the current optical represantation and with a change of that …
@auge8472 auge8472 force-pushed the auge8472:html5 branch from 0e248e2 to f601d15 Dec 18, 2019
@auge8472
Copy link
Contributor Author

auge8472 commented Dec 18, 2019

1 successful check

Yeah! :-)

@auge8472 auge8472 requested a review from LordAro Dec 18, 2019
Copy link
Member

LordAro left a comment

Presuming removing background.png won't have a knock-on affect for the sub-sites not hosting their own...

@auge8472
Copy link
Contributor Author

auge8472 commented Dec 18, 2019

Presuming removing background.png won't have a knock-on affect for the sub-sites not hosting their own...

Ha! I didn't check that. ...

As far as I can see, it is only the servers page/subdomain (servers.openttd.org) that uses the same layout in a copy? If so, the subdomain seems to use a copy of the image from the subdomain media.openttd.org (https://media.openttd.org/media/images/layout/background.png). Same is valid for bananas.openttd.org.

The main page inserts the image directly from the domain www.openttd.org (https://www.openttd.org/static/img/layout/background.png).

It might be possible that one is a link to the other source on the file system of the server. But that's something I can't check. ;-)

@TrueBrain
Copy link
Member

TrueBrain commented Dec 18, 2019

This repository is fully separate from the rest of the infrastructure. This includes reuse of images etc ;)

We used to host all images on media.openttd.org indeed (back in the days that was normal :P). So all the old infrastructure still uses that.

So yeah, this should be save to use :) Good analysis ;)

@LordAro LordAro merged commit 9e862fa into OpenTTD:master Dec 27, 2019
1 check passed
1 check passed
website Build #20191218.1 succeeded
Details
@TrueBrain
Copy link
Member

TrueBrain commented Dec 28, 2019

https://www.staging.openttd.org/

Screenshot on the homepage is aligned wrong now :( Not sure what went wrong :D

@auge8472
Copy link
Contributor Author

auge8472 commented Dec 29, 2019

Screenshot on the homepage is aligned wrong now :( Not sure what went wrong :D

Is this cleared with #121?

@LordAro
Copy link
Member

LordAro commented Dec 29, 2019

Indeed, should be fine now

@auge8472 auge8472 deleted the auge8472:html5 branch Dec 29, 2019
@auge8472
Copy link
Contributor Author

auge8472 commented Dec 29, 2019

Indeed, should be fine now

Thank you for the clarification. It's nice to see so many small but effectfull changes that followed during the last days. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.