Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflowing nav #122

Merged
merged 1 commit into from Dec 28, 2019
Merged

Fix overflowing nav #122

merged 1 commit into from Dec 28, 2019

Conversation

@Milek7
Copy link
Contributor

Milek7 commented Dec 28, 2019

It makes it wider than content, but it looks better than now anyway..
Modified it to use flex layout too.

@TrueBrain
Copy link
Member

TrueBrain commented Dec 28, 2019

This PR needs more context. "better than now anyway" is a vague statement. In the current version, on my OS and browser, I see no issues with the navigation. So please elaborate what you try to fix.

@Milek7
Copy link
Contributor Author

Milek7 commented Dec 28, 2019

obraz

@TrueBrain
Copy link
Member

TrueBrain commented Dec 28, 2019

holds hands
OS? Browser? Version?
:)

@Milek7
Copy link
Contributor Author

Milek7 commented Dec 28, 2019

Firefox Developer Edition 72.0b10 and Chromium 79.0.3945.88 on Linux.
But I don't think this is any actionable information ;) I guess it is related to differences in font size rendering.

@LordAro
Copy link
Member

LordAro commented Dec 28, 2019

I see it too, Arch Linux, Chromium (79) & Firefox (71). Might be something to do with the font loaded? - Trebuchet MS is requested, Chrome says it's loading DejaVu Sans

I'd still like to see a "better" solution that removes the need for the left/right navigation divs, but this will do for now.

@TrueBrain
Copy link
Member

TrueBrain commented Dec 28, 2019

Now we are getting to the core of the issue :D

I guess Linux doesn't have Trebuchet MS, and the site was designed with that font in mind. Guess that would mean more things break :)

@Milek7 Milek7 force-pushed the Milek7:patch-2 branch from 4827ecc to 1a09d00 Dec 28, 2019
@Milek7
Copy link
Contributor Author

Milek7 commented Dec 28, 2019

Ok, widening wasn't necessary, just decreased minimum padding.
After fix:
obraz

@Milek7 Milek7 changed the title Widen nav to 825px Fix overflowing nav Dec 28, 2019
@LordAro LordAro merged commit 654adfe into OpenTTD:master Dec 28, 2019
1 check passed
1 check passed
website Build #20191228.8 succeeded
Details
@auge8472
Copy link
Contributor

auge8472 commented Dec 29, 2019

Playing the Advocatus Diaboli (the devils advocate):

Ok, widening wasn't necessary, just decreased minimum padding.

That's o.k. in English language, it's o.k. with the intended font sizes and it's o.k., so long as noone want's to introduce translations of the UI with their different word lengths. If one of the assumtions failes, the navigation is vulnerable to overflow again.

In the end the site needs a contruction that is able to overflow without breaking design elements like the current background of the navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.