Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Rework banner image use more modern CSS, and replace all images #132

Merged
merged 3 commits into from Dec 31, 2019

Conversation

@LordAro
Copy link
Member

LordAro commented Dec 30, 2019

With some other stuff

After:

flexboxes all the way down, and not a float in sight. Also shiny linear-gradients and border-radiuses instead of having it hardcoded into the banner images

Images replaced by a random selection from TT Screenshot of the month, and cropped by myself. Some of the snowy images don't have great contrast with the text, but...

@LordAro
Copy link
Member Author

LordAro commented Dec 30, 2019

A nice addition would be to make it cycle through the banner images a bit more regularly than just choosing the week day when the site was last built

.gitignore Outdated Show resolved Hide resolved
@TrueBrain
Copy link
Member

TrueBrain commented Dec 30, 2019

A nice addition would be to make it cycle through the banner images a bit more regularly than just choosing the week day when the site was last built

To me this always has been perfect. As we publish a new site every day, this means we have another banner every day. Rare people notice this btw, but it is just a cool gimmick. Every day another one seems regular enough to me!

@LordAro
Copy link
Member Author

LordAro commented Dec 30, 2019

Do we publish a new site every day? Or are you just referring to the regularity that we're making changes at the moment?

@TrueBrain
Copy link
Member

TrueBrain commented Dec 30, 2019

Do we publish a new site every day? Or are you just referring to the regularity that we're making changes at the moment?

No ... the site gets a new publish every day. Well, every time there is a new nightly, strictly speaking, which has a 90% track record or something silly. So yes, every day. How else do you think the new nightly shows up on the website :D

pages/index.html Outdated Show resolved Hide resolved
@LordAro LordAro force-pushed the LordAro:morestuff branch from edc3ae9 to 05f1a48 Dec 30, 2019
static/css/index.css Outdated Show resolved Hide resolved
@LordAro LordAro force-pushed the LordAro:morestuff branch from 05f1a48 to 788f58e Dec 30, 2019
@TrueBrain
Copy link
Member

TrueBrain commented Dec 30, 2019

@auge8472 this looks good to me; do you have any further comments before I merge this?

@auge8472
Copy link
Contributor

auge8472 commented Dec 31, 2019

this looks good to me; do you have any further comments before I merge this?

@TrueBrain I personally don't like the solution for the banner menu but I am not able to present the promised proposal for an alternative solution without changes in the HTML-source as fast as I thought I would. So yes, I have no further comments. :-)

@LordAro
Copy link
Member Author

LordAro commented Dec 31, 2019

Feel free to say if there's anything specific I can do something about

@TrueBrain
Copy link
Member

TrueBrain commented Dec 31, 2019

We don't have to fix everything at once :) Iterations are fine :)

@TrueBrain TrueBrain merged commit 0d87525 into OpenTTD:master Dec 31, 2019
2 checks passed
2 checks passed
Docker build
Details
website Build #20191230.11 succeeded
Details
@TrueBrain
Copy link
Member

TrueBrain commented Dec 31, 2019

Now it is on staging, I can compare it to the old version :D Overall, it looks really nice :)

One comment:
image
This looks really odd. Can't we make the image padding left/right identical some how?

Suggested fix in #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.