Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding corrections as consequences of #130 #133

merged 3 commits into from Dec 30, 2019


Copy link

@auge8472 auge8472 commented Dec 30, 2019

It started as pure fixes but landed as medium changes.

Icons in the headings

  • adjusted the padding of the headings (h3) to leave place for the icons
  • remove the margin from the headings and put a right padding to the containing div instead (same 10px as left padding)
  • remove all div.section-icon and put the icon to the headings itself, removed also the CSS-ruleset for div.section-icon

That makes the HTML-structure a bit smaller and simplifies the CSS-ruleset a bit

Screenshot thumbnail on the home page

  • replace the overly nested structure with divs with a figure-figcaption combination (HTML5 rules)
  • removed the div for the a and the img in it and give its task directly to the a
  • removed the height from #screenshot-image because the fixed height in combination with the box-model: border-box; caused the broken layout, mentioned in #130
  • complement the width- and height-attributes of the image with CSS-rules that makes the image large as possible in the main container #index-right
  • removed the placeholder for the alt-attribute of the image because the planned content is the same as the description below the image (now stored in figcaption); the text would be displayed twice when the image was broken and read twice for screenreader users (once from the alt-attribute and a second time from the description below the image). The empty alt-attribute itself has to stay there because if it would be removed, a screenreader would read the filename of the image.
Copy link

@LordAro LordAro left a comment

Think we should be able to remove the section-header div as well... But later :)

@LordAro LordAro merged commit 14a1f1b into OpenTTD:master Dec 30, 2019
2 checks passed
Copy link
Contributor Author

@auge8472 auge8472 commented Dec 30, 2019

Think we should be able to remove the section-header div as well... But later :)

Yes and yes. :-)

@auge8472 auge8472 deleted the bm-corrections branch Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants