Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version detection, top-left banner, and add deployment badges #137

Merged
merged 3 commits into from Jan 8, 2020

Conversation

@TrueBrain
Copy link
Member

TrueBrain commented Jan 7, 2020

Two totally unrelated fixes, but I was lazy. Sorry.

Old banner:
image

New banner:
image

TrueBrain added 2 commits Jan 7, 2020
Otherwise the wrong version will be used as primary tag.
The "Download" URLs are very far apart, and the margin to the border
is very closeby. This gives a very odd look&feel. By moving the
"Download" URLs closer together and increase the margin a bit, the
banner feels more at ease.
@TrueBrain TrueBrain changed the title Fix version detection and top-left banner Fix version detection, top-left banner, and add deployment badges Jan 7, 2020
@@ -75,12 +75,9 @@ body > header {
border-radius: 6px;
list-style: none;
margin: 0;
padding: 3px 10px 3px 45px;
padding: 6px 10px 6px 45px;

This comment has been minimized.

Copy link
@auge8472

auge8472 Jan 8, 2020

Contributor

After the merge of my PR with the now more or less reverted change (#136) I for myself was a bit nerved by the slim padding. I made this change because of the compression of the text lines with a greater font size than the intended 11px (I use a minimal font size of 14px in my browser).

Now it looks more pleasing again but IMHO the site should take dissenting font and element sizes into account in a futury layout.

@LordAro
LordAro approved these changes Jan 8, 2020
@LordAro LordAro merged commit 236bde5 into OpenTTD:master Jan 8, 2020
2 checks passed
2 checks passed
Docker build
Details
website Build #20200107.2 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.