Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update both Python and Ruby dependencies #163

Merged
merged 3 commits into from Sep 3, 2020
Merged

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Sep 3, 2020

No description provided.

TrueBrain added 3 commits Sep 3, 2020
Also fix the .gitignore to ignore Python files.
This brings Jekyll to version 4, which is not only a lot faster,
also has dependencies that no longer have active CVEs.
- nginx.default.conf
- requirements.base
- requirements.txt
- thirdparty
- vendor
Copy link
Member

@LordAro LordAro Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these excludes no longer necessary or something? Why removed?

Copy link
Member Author

@TrueBrain TrueBrain Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -25,15 +25,14 @@ COPY Gemfile Gemfile.lock /source/

RUN apk --no-cache add \
build-base \
libstdc++ \
Copy link
Member

@LordAro LordAro Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious what (newly) depends on this

Copy link
Member Author

@TrueBrain TrueBrain Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libsaas, as it turns out.

LordAro
LordAro approved these changes Sep 3, 2020
@TrueBrain TrueBrain merged commit 7ba4702 into OpenTTD:master Sep 3, 2020
3 checks passed
@TrueBrain TrueBrain deleted the bump branch Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants