Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: support binary distribution via our new infrastructure #23

Merged
merged 1 commit into from Jan 21, 2019

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 19, 2019

Binaries are uploaded to a CDN. listing.txt and latest.txt help
navigate the CDN.

Currently both infrastructures are supported. We will slowly
migrate everything to the new infrastructure, once everything is
live and in working order.

@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jan 19, 2019

Would benefit from link validation.

@TrueBrain
Copy link
Member Author

@TrueBrain TrueBrain commented Jan 19, 2019

image
image

Binaries are uploaded to a CDN. listing.txt and latest.txt help
navigate the CDN.

Currently both infrastructures are supported. We will slowly
migrate everything to the new infrastructure, once everything is
live and in working order.
---

For OpenTTD you can use the original Transport Tycoon Deluxe data files (you need to own a Transport Tycoon Deluxe CD).
There are also the free alternatives: [OpenGFX (graphics)](http://dev.openttdcoop.org/projects/opengfx), [OpenSFX (sound)](http://dev.openttdcoop.org/projects/opensfx), and [OpenMSX (music)](http://dev.openttdcoop.org/projects/openmsx).
These can be installed automatically by the Windows and OS/2 installers.
Please refer to the [readme](https://binaries.openttd.org/nightlies/trunk/@@version@@/readme.txt) for more information.
Please refer to the [readme](https://openttd.ams3.cdn.digitaloceanspaces.com/openttd-nightlies/@@version@@/README.md) for more information.
Copy link
Member

@LordAro LordAro Jan 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given it's likely to change at some point, perhaps putting the URL in a variable somewhere might be appropriate?

Copy link
Member Author

@TrueBrain TrueBrain Jan 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah; more of these need attention, as too many things are hardcoded. But I have yet to find a way to make this easier to template (I now wrote a custom 'template engine', that replaces @@Version@@). So I am going to create an issue out of this.

@@ -1,3 +1,3 @@
---
folder: extra/catcodec
folder_old_infrastructure: extra/catcodec
Copy link
Member

@LordAro LordAro Jan 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you get around to making a readme, I'd recommend a list of all the "custom" variables (and what they're for)

Copy link
Member Author

@TrueBrain TrueBrain Jan 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are temporary during migration, but I agree. Will do.

Copy link
Contributor

@andythenorth andythenorth left a comment

Approving this on 'works for me' basis. I ran a link checker over it, no 404s, only 200s, 301s, 302s, 307s, assuming they're all as expected.

WAVE toolbar reports multiple accessibility errors on the downloads page. They're pre-existing, I'll file an issue or PR for those separately.

@TrueBrain TrueBrain merged commit 816f3be into OpenTTD:master Jan 21, 2019
1 check passed
@TrueBrain TrueBrain deleted the new_cdn branch Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants