Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make the size of the fast-download-header content aware #79

Merged
merged 3 commits into from Apr 13, 2019

Conversation

@auge8472
Copy link
Contributor

@auge8472 auge8472 commented Apr 11, 2019

  • Replace the background image of the fast-download-header with a semi transparent background colour with alpha channel (rgba system, compatibility table on caniuse.com) and an invisible border to make corners rounded.
  • Remove the width and height definitions of the block to allow an automatic resizing in case of a third text line (download link for beta or RC).
  • Cut the parcel from the original background image and set it into the left top corner of the block.

download header with two links
resized download header with three links

See #77 for discussion.

@LordAro
Copy link
Member

@LordAro LordAro commented Apr 11, 2019

This is similar to what I was planning on doing. download-fast.png should be deleted now? Or is it referenced somewhere else?

@auge8472
Copy link
Contributor Author

@auge8472 auge8472 commented Apr 11, 2019

download-fast.png should be deleted now? Or is it referenced somewhere else?

I haven't searched for another reference. I will look through the code and will add another commit to remove the old background image if I doesn't find a further occurence.

edit: Found no further use of download-fast.png and deleted it in a second commit.

@LordAro LordAro mentioned this pull request Apr 12, 2019
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Apr 13, 2019

Hmm .. now the icon is not aligned with 3 lines (nitpicking ftw! :D) I guess this can be fixed with #download-fast-3 setting the image on a slightly different place?

Would you mind terribly doing that? Otherwise my OCD would trigger every time we have a testing build available :D

PS: thank you so much for this! We have many more of these things to convert .. CSS came a long way in 10+ years, but our website did not ;)

@LordAro
Copy link
Member

@LordAro LordAro commented Apr 13, 2019

I "backported" my changes from my layout-refactor branch, looks OK to me?

@TrueBrain TrueBrain merged commit d1c7c6f into OpenTTD:master Apr 13, 2019
1 check passed
@auge8472 auge8472 deleted the dl-header branch Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants