Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General layout refactor #80

Closed
wants to merge 4 commits into from
Closed

Conversation

@LordAro
Copy link
Member

LordAro commented Apr 12, 2019

Refactors the site html, css & images to be more modern (not in looks, but code)

Seems to be mostly working

IANAWD (I am not a web developer)

@LordAro LordAro force-pushed the LordAro:layout-refactor branch from 92860e2 to 1524dfd Apr 13, 2019
@LordAro LordAro marked this pull request as ready for review Apr 13, 2019
@LordAro LordAro force-pushed the LordAro:layout-refactor branch from 1524dfd to ce794d9 Apr 13, 2019
@auge8472
Copy link
Contributor

auge8472 commented Apr 13, 2019

I am working on my own draft for a new HTML structure. As I can see, you tend to go into the same direction, but not so far as me. I want to open a similar PR with my own ideas, not for competition but for discussing and comparing ideas. Is that o.k. for you?

auge8472 added a commit to auge8472/OpenTTD-website that referenced this pull request Apr 13, 2019
@LordAro
Copy link
Member Author

LordAro commented Apr 13, 2019

Oooh, very interesting. I like what you've done, especially with the <article> usage and the lack-of-href in the nav. And perhaps more importantly (from a @TrueBrain perspective) your stuff is already split up into individual commits ^^
Given you've got most of the stuff that I have already (and a bit more), I think perhaps the best course of action would be for you to just take bits and pieces from this PR and apply it to yours? My changes thus far go a bit deeper in the CSS and changing the page structures

auge8472 added a commit to auge8472/OpenTTD-website that referenced this pull request Apr 14, 2019
This commit follows the change in @LordAros PR OpenTTD#80.
TrueBrain added a commit that referenced this pull request Apr 14, 2019
This commit follows the change in @LordAros PR #80.
@TrueBrain
Copy link
Member

TrueBrain commented Dec 7, 2019

Ping @LordAro : three tickets with near identical suggested changes, but no activity in a long time. What do you want to do with the pull requests?

@LordAro
Copy link
Member Author

LordAro commented Dec 31, 2019

Closing this in preference to the many other PRs that have happened since

@LordAro LordAro closed this Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.