Smaller alerts #568
Merged
Smaller alerts #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Slightly smaller close button elsewhere as well from *bootstrap* default * Change padding on alerts to match * Still alerts but more focus on user content than notices... plus if a larger notice is needed we can pack more in. **NOTES**: * Since we are interim deciding if *bootswatch* is going to be replaced by our own custom theme adding a "Staged" area that isn't normally part of that theme. Both Staged and Unstaged sections are overrides to that theme and should be maintained on dep updates.
Martii
added
UI
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Feb 6, 2015
* Don't affect non-small alerts * Assuming our main nav will always be at top... snug up the `margin-bottom` * Add class to reminders * Snug up reminders * Undo default alert padding change and *(x) close from OpenUserJS#568 and handle only in reminders that are small * Use some more LESS syntax in staged area * Add *bootstrap*s default fade effect on close... the timing is a bit short so not really noticable but if you stare it closely it does use CSS3. **NOTES**: * When removing reminders, which are currently static in the view, leave the parent `reminders` div in to maintain current spacing especially when closed.
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Feb 7, 2015
* *bootstrap* notes ** Don't set initial height... this is what was making it open/close automatically... needed in latest *bootstrap* ** `floor` and adjust reminders to top/bottom padding only otherwise viewport horizontal scrollbar appears with this *bootstrap* ... Related to OpenUserJS#484 and starting at OpenUserJS#568 ** Remove unused classes at `/user/add/scripts` so it doesn't color differently... e.g. this is probably a bug that was fixed in latest *bootstrap* as well as possible improper usage in our code. * *mongoose* update * *sanitize-html* update Closes OpenUserJS#379
This was referenced Feb 7, 2015
Merged
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Feb 8, 2015
* Do this in case someone hotlinks lower in the page and ends up missing these when traversing Applies to OpenUserJS#573 and OpenUserJS#484 and more for OpenUserJS#567 and start of OpenUserJS#568
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTES: