Skip to content

Conversation

@Martii
Copy link
Member

@Martii Martii commented Feb 7, 2015

  • bootstrap notes
    • Don't set initial height... this is what was making it open/close automatically... needed in latest bootstrap
    • floor and adjust reminders to top/bottom padding only otherwise viewport horizontal scrollbar appears with this bootstrap ... Related to Google OpenID 2.0 Deprecation #484 and starting at Smaller alerts #568
    • Remove unused classes at /user/add/scripts so it doesn't color differently... e.g. this is probably a bug that was fixed in latest bootstrap as well as possible improper usage in our code.
  • mongoose update
  • sanitize-html update

Closes #379

* *bootstrap* notes
** Don't set initial height... this is what was making it open/close automatically... needed in latest *bootstrap*
** `floor` and adjust reminders to top/bottom padding only otherwise viewport horizontal scrollbar appears with this *bootstrap* ... Related to OpenUserJS#484 and starting at OpenUserJS#568
** Remove unused classes at `/user/add/scripts` so it doesn't color differently... e.g. this is probably a bug that was fixed in latest *bootstrap* as well as possible improper usage in our code.
* *mongoose* update
* *sanitize-html* update

Closes OpenUserJS#379
@Martii Martii added bug You've guessed it... this means a bug is reported. UI Pertains inclusively to the User Interface. migration Use this to indicate that it may apply to an existing or announced migration. labels Feb 7, 2015
Martii added a commit that referenced this pull request Feb 7, 2015
@Martii Martii merged commit aad3c1d into OpenUserJS:master Feb 7, 2015
@Martii Martii added this to the #249 milestone Feb 7, 2015
@Martii Martii deleted the someDepUpdates branch February 7, 2015 22:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug You've guessed it... this means a bug is reported. migration Use this to indicate that it may apply to an existing or announced migration. UI Pertains inclusively to the User Interface.

Development

Successfully merging this pull request may close these issues.

Why are we not using bootstrap > 3.1.1?

1 participant