Skip to content

Browser compatibility fix for Chromium/Chrome based browsers and Opera P... #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Martii merged 1 commit into from
Feb 8, 2015
Merged

Browser compatibility fix for Chromium/Chrome based browsers and Opera P... #576

Martii merged 1 commit into from
Feb 8, 2015

Conversation

@Martii
Copy link
Member

@Martii Martii commented Feb 8, 2015

...resto

  • focus event doesn't appear to be handled properly in two other browsers so reverting comment reply box handler event... this may invalidate Change event capture for reply box and reminders #575 in browsers that handle this incorrectly. activate and create do nothing additional in tested browsers... Mozilla rules again. ;)
  • Restores ability to comment in those tested browsers without (the need for an additional) scroll and/or resize

NOTES:

  • Reverse code migration. e.g. browser regression testing failed
  • Leaving this event in for the reminders as a browser Unit Test to see who fixes what... logically Moz/IE handles this as expected.

Browser compatibility fix for Chromium/Chrome based browsers and Oper…
6f7e96e 
…a Presto

* `focus` event doesn't appear to be handled properly in two other browsers so reverting comment reply box handler event... this may invalidate OpenUserJS#575 in browsers that handle this incorrectly. `activate` and `create` do nothing additional in tested browsers... Mozilla rules again. ;)
* Restores ability to comment in those tested browsers without scroll and resize
@Martii Martii added bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. UI Pertains inclusively to the User Interface. migration Use this to indicate that it may apply to an existing or announced migration. labels Feb 8, 2015
Martii added a commit that referenced this pull request Feb 8, 2015
@Martii
Merge pull request #576 from Martii/browserCompatibilityFixEvent
6334442 
Browser compatibility fix for Chromium/Chrome based browsers and Opera P...

Auto-merge
@Martii Martii merged commit 6334442 into OpenUserJS:master Feb 8, 2015
@Martii Martii deleted the browserCompatibilityFixEvent branch February 8, 2015 23:38
@Martii Martii added the needs testing Anyone can add this but it is primarily there for the Assignee indicating that Testers are wanted. label Feb 10, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration. needs testing Anyone can add this but it is primarily there for the Assignee indicating that Testers are wanted. UI Pertains inclusively to the User Interface.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Martii