Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mod Feature: Remove content from "Flagged Items" #642

Open
sizzlemctwizzle opened this issue Jun 10, 2015 · 13 comments
Open

Mod Feature: Remove content from "Flagged Items" #642

sizzlemctwizzle opened this issue Jun 10, 2015 · 13 comments
Assignees
@Martii
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. feature Something we don't already have implemented to the best of knowledge but would like to see. UI Pertains inclusively to the User Interface.

Comments

@sizzlemctwizzle
Copy link
Member

The flag count would not be reset but insteadcontent.flagged = false; (pardon). If the content gets flagged again, it would once again show up for review and possible removal/pardoning.
@sizzlemctwizzle sizzlemctwizzle added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jun 10, 2015
This was referenced Jun 10, 2015
Closed
Closed
@sizzlemctwizzle sizzlemctwizzle added feature Something we don't already have implemented to the best of knowledge but would like to see. and removed enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. labels Jun 10, 2015
@Martii
Copy link
Member

Martii commented Jun 10, 2015

"Pardoning" seems like an interesting concept. :)

@Martii
Copy link
Member

Martii commented Oct 19, 2015

Just realized this is a dupe of #134 although it's better worded here! :) Closing the other issue.

This was referenced Oct 19, 2015
Closed
Closed
@sizzlemctwizzle
Copy link
Member Author

I created a nearly exact duplicate of another issue I created almost exactly a year later... I think I might be getting old...

@Martii Martii self-assigned this Oct 21, 2015
@Martii
Copy link
Member

Martii commented Oct 22, 2015

Naw ... just getting wiser. :)

Questions:

  1. Only allow pardoning if there aren't higher roles than yourself that have already flagged?
  2. Can Admins+ pardon too or just a "capture the flag and toss it in file 13" like it is currently?
  3. Track who pardons and perhaps how many times?
  4. I assume any data stored would be in the Flag model or are we going to do this on User?
  5. …
  6. ?

@sizzlemctwizzle
Copy link
Member Author

  1. Admin+ can't flag so this wouldn't be an issue. However this would be an issue with who can bring something back after it had been removed. Although not that big of a deal since the group of users with roles above admin are fixed.
  2. Admin+ can remove (sent to the graveyard) flags from content directly since they can actually inspect flags, unlike mods. Pardoning is a mod feature.
  3. There should definitely be a record of pardoning.
  4. I'd store this information on the content in the new flags object you added.

@Martii
Copy link
Member

Martii commented Oct 22, 2015

  1. Still has the question... let's say I flag a user/script (as Admin) with a valid reason for long term watching... then it shows up in critical list... and Moderator comes along and pardons it... I see an issue there.

@sizzlemctwizzle
Copy link
Member Author

Okay, here is the problem. I never remember anyone with a role of admin or above being able to flag anything. In fact, I made a conscious decision not to allow this: see my code in a very early version of libs/flag.js (the module that controls the rules behind flagging).

I did some research and found out that apparently @Zren took it upon himself to silently remove this logic, even though why it's there is clearly commented. It was a long time ago, and I guess I just never realized I could flag things.

I would like this reversed. Admins+ are not supposed to be part of the moderation system. They just take action when needed. My intended design has a clear separation between admins+ and all other users.

@Martii
Copy link
Member

Martii commented Oct 22, 2015

Admins+ are not supposed to be part of the moderation system. They just take action when needed.

Well I can restore that part but I would still like to be able to long term track a user... but I can do that with my Martii account since that is moderator level... eventually I'll take action as Admin with Marti account but I usually like to give people a chance to make amends before I go killing their script/account... (unless it's so critical they are gone nearly immediately).

Thanks for the insight and clarification.

@sizzlemctwizzle
Copy link
Member Author

I think it's fine for you to have a mod account to flag things you want to
keep track of and give the author/user a chance to fix things. We don't
have any mods so you're kind of forced to fill the dual role of a mod/admin.
On Oct 22, 2015 4:24 PM, "Marti Martz" notifications@github.com wrote:

Admins+ are not supposed to be part of the moderation system. They just
take action when needed.

Well I can restore that part but I would still like to be able to long
term track a user... but I can do that with my Martii account since that
is moderator level... eventually I'll take action as Admin with Marti
account but I usually like to give people a chance to make amends before I
go killing their script/account.

Thanks for the insight and clarification.

—
Reply to this email directly or view it on GitHub
#642 (comment)
.

@Martii
Copy link
Member

Martii commented Oct 22, 2015

Well I still have that recommendation for a Moderator if he accepts but the Moderation tools have to be complete otherwise anyone won't bother... that's why I assigned myself to these issues... so hopefully we can find the right balance and understanding. I've been a sysop for decades on many other protocols so this isn't much extra work for me having dual roles... but not forever hopefully... plus it helps me understand what the goal is/was. :)

Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Oct 22, 2015
Revert change on who can flag depending on role
6193328 
* Some STYLEGUIDE.md conformance in this function
* Restored the comments too

**NOTES**
Confirmed that User, Author and Moderator can still flag in the UI... Admin can't as per role logic at all methods... reset dev DB flags and pro DB flags to reflect this reversion

See also:
* OpenUserJS@df552c7#diff-f968c831502e727188f4ce4cf56f755fL11
* OpenUserJS#642 (comment)

Applies to OpenUserJS#642
@Martii Martii mentioned this issue Oct 22, 2015
Merged
@Martii
Copy link
Member

Martii commented Oct 22, 2015

Okay so followup question for 1) ...

  1. Use case... if a script is flagged by anyone in the moderation system and Moderator 1 comes along and flags the same content... can a Moderator 2 pardon? e.g. equal role check (skip)?

@sizzlemctwizzle
Copy link
Member Author

No. A moderator cannot pardon content flagged by another moderator. In a
situation like this, if the second moderator believes the first moderator
made a mistake by flagging, he/she should contact an admin to resolve the
situation.
On Oct 22, 2015 6:37 PM, "Marti Martz" notifications@github.com wrote:

Okay so followup question for 1) ...

  1. Use case... if a script is flagged by anyone in the moderation system
    and Moderator 1 comes along and flags the same content... can a Moderator 2
    pardon? e.g. equal role check?

—
Reply to this email directly or view it on GitHub
#642 (comment)
.

@Martii
Copy link
Member

Martii commented Oct 18, 2018 •
edited

@sizzlemctwizzle

Re:

A button that lets moderators change a script in the flagged state to not flagged.

In order to pardon a moderator must know the reason why a script is flagged. We can make the reporter invisible but without this info they can't pardon based off guessing why it was flagged.

Martii added a commit to Martii/OpenUserJS.org that referenced this issue Jun 3, 2021
@Martii
Move around flagging a bit.
cf20fa6 
* Moderators can now see the reason why something is flagged. This is absolutely necessary to evaluate if a pardon occurs. Moderators may currently additionally flag with their requested intentions/summary. This has been idle on response for several years and really has to be implemented this way.
* Moderators will only see Rank so that there isn't a flame war since @sizzlemctwizzle defined it as ~"dime a dozen".
* Moved flagger *(renamed to match)* to mod panel and put a danger class on it for those that can remove to prevent accidental removal *(hasn't happened yet but good idea)*
* Some twiddling with class usage in *bootstrap* UI

Applies to OpenUserJS#642

Note(s):
* This version of mustache generates a lot of extra UI code due to `{{#isAdmin}}` not being in scope in certain circumstances.
@Martii Martii mentioned this issue Jun 3, 2021
Merged
Martii added a commit that referenced this issue Jun 3, 2021
@Martii
Move around flagging a bit. (#1818)
38ddd8a 
* Moderators can now see the reason why something is flagged. This is absolutely necessary to evaluate if a pardon occurs. Moderators may currently additionally flag with their requested intentions/summary. This has been idle on response for several years and really has to be implemented this way.
* Moderators will only see Rank so that there isn't a flame war since @sizzlemctwizzle defined it as ~"dime a dozen".
* Moved flagger *(renamed to match)* to mod panel and put a danger class on it for those that can remove to prevent accidental removal *(hasn't happened yet but good idea)*
* Some twiddling with class usage in *bootstrap* UI

Applies to #642

Note(s):
* This version of mustache generates a lot of extra UI code due to `{{#isAdmin}}` not being in scope in certain circumstances.

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Jan 17, 2022
@Martii
Hide flags nav for those that shouldn't have it.
3f98e0f 
* Ref: Post OpenUserJS#642 (comment)
* Bloat up *mu2* *(mustache)* with some deep conditionals instead to achieve this. Not that this is a new thing.
* Also expose "Yes" to Moderators for ambiguity. Parallel to actual flag list ambiguity. This can change if discussed with establishing owner but content will be semi-blocked when implemented *(fully on homepages and partial currently on flagged moderation lists)*.

Post OpenUserJS#1943 OpenUserJS#1942 OpenUserJS#785

NOTE:
* If you don't "trust the admin" going up the hierarchy can block the content but need to know counts at least for manual validation and actions upon moderation.
@Martii Martii mentioned this issue Jan 17, 2022
Merged
Martii added a commit that referenced this issue Jan 17, 2022
@Martii
Hide flags nav for those that shouldn't have it. (#1944)
c63d472 
* Ref: Post #642 (comment)
* Bloat up *mu2* *(mustache)* with some deep conditionals instead to achieve this. Not that this is a new thing.
* Also expose "Yes" to Moderators for ambiguity. Parallel to actual flag list ambiguity. This can change if discussed with establishing owner but content will be semi-blocked when implemented *(fully on homepages and partial currently on flagged moderation lists)*.

Post #1943 #1942 #785

NOTE:
* If you don't "trust the admin" going up the hierarchy can block the content but need to know counts at least for manual validation and actions upon moderation.

Auto-merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Martii Martii

Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. feature Something we don't already have implemented to the best of knowledge but would like to see. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sizzlemctwizzle @Martii