Skip to content

parser: Add record returns to models #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2025
Merged

parser: Add record returns to models #306

merged 3 commits into from
May 28, 2025

Conversation

@flofriday
Copy link
Contributor

Models can now return record types. #247

@flofriday
parser: Add record returns to models
12bc58a 
Models can now return record types. #247
@flofriday flofriday requested a review from AndreasKrall May 28, 2025 14:59
@github-actions github-actions bot added enhancement New feature or request frontend This is frontend related labels May 28, 2025
AndreasKrall
AndreasKrall approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@AndreasKrall AndreasKrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine. But you should also add a test where such a model is instantiated.

@AndreasKrall AndreasKrall merged commit 959244d into master May 28, 2025
9 checks passed
@AndreasKrall AndreasKrall deleted the feature/add-record-returns-to-models branch May 28, 2025 22:08
@AndreasKrall AndreasKrall mentioned this pull request May 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreasKrall AndreasKrall AndreasKrall approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request frontend This is frontend related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flofriday @AndreasKrall