Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign-req does not check for an existing certificate #629

Closed
TinCanTech opened this issue Aug 8, 2022 · 5 comments
Closed

sign-req does not check for an existing certificate #629

TinCanTech opened this issue Aug 8, 2022 · 5 comments
Assignees
Labels
Applicable to v3.0.x PRs welcome BUG URGENT BLOCKER: Line in the Sand

Comments

@TinCanTech
Copy link
Collaborator

TinCanTech commented Aug 8, 2022

Easy to reproduce:

  • Create a PKI and CA certificate.
  • Build a new client: build-client-full client-1 nopass
  • Try to build another new client named client-1,
    This will correctly fail.
  • Use sign-req client client-1
    This will over-write the existing certificate, without warning.
    It will also add another record to index.txt for client-1.
@TinCanTech TinCanTech self-assigned this Aug 8, 2022
@TinCanTech TinCanTech added the BUG label Aug 8, 2022
@TinCanTech TinCanTech added this to the v3.1.1-RC1 milestone Aug 8, 2022
@tecoboot
Copy link

tecoboot commented Aug 8, 2022

Verified :-)

@TinCanTech
Copy link
Collaborator Author

Verified :-)

What did you verify, the bug or the fix ?

@tecoboot
Copy link

tecoboot commented Aug 8, 2022

The fix works well.

@TinCanTech
Copy link
Collaborator Author

This must to go into release.

@TinCanTech TinCanTech reopened this Aug 10, 2022
@TinCanTech TinCanTech added URGENT BLOCKER: Line in the Sand Applicable to v3.0.x PRs welcome labels Aug 10, 2022
@TinCanTech
Copy link
Collaborator Author

Closed via 5b4fd2b

Labeled for version 3.0.x port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applicable to v3.0.x PRs welcome BUG URGENT BLOCKER: Line in the Sand
Projects
None yet
Development

No branches or pull requests

2 participants