Join GitHub today
Add an option in setup to use ProgramDataFolder for Vista and above #8
Sorry for the delay, I didn't have notifications turned on so I missed this and many other pull requests. In general this looks fine. However, before merging this I'd need confirmation of what happens if
Does the first OpenVPN-GUI launch overwrite any of the registry keys your modified NSIS installer created? I'm not sure how OpenVPN-GUI behaves if some of its registry keys are present and some are missing.
This patch, does :
The registry entries in "HKEY_LOCAL_MACHINE\SOFTWARE\OpenVPN" are mostly used by the OpenVPN Service when he had to look for Services .OVPN files to start automatically and for logs.
The registry entries in "HKEY_LOCAL_MACHINE\SOFTWARE\OpenVPN-GUI" are used by OpenVPN GUI to find the .OVPN configuration files and locate log files
I built experimental installers based on your latest patches:
I tested the latter installer on a Windows 8.1 64-bit VM and immediately ran into issues. It does not seem to matter whether SecProgData is checked or not: the registry keys will always end up pointing to the ProgramData folder. Can you reproduce this behavior yourself?
Besides this the code itself looks good. That said, would it be possible to create a prefix variable based on checked/unchecked value of the SecProgData, and use that to build the correct paths? This would make code slightly cleaner.