New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Korean localization by JoungKyun Kim #155

Merged
merged 3 commits into from May 10, 2017

Conversation

Projects
None yet
4 participants
@Joungkyun
Contributor

Joungkyun commented Apr 13, 2017

Add Korean localization file. (openvpn-gui-res-kr.rc).
This file is written by UTF-8.

Thanks.

@mattock

This comment has been minimized.

Show comment
Hide comment
@mattock

mattock Apr 15, 2017

Member

Thanks! Technically the changes look fine, but I'll try to get somebody to review the actual translation.

Member

mattock commented Apr 15, 2017

Thanks! Technically the changes look fine, but I'll try to get somebody to review the actual translation.

@selvanair

Can't comment on the translation, but here are few comments.

Show outdated Hide outdated res/openvpn-gui-res-kr.rc
LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT
BEGIN
LTEXT "사용자:", 0, 6, 9, 50, 10
LTEXT "암호:", 0, 6, 26, 50, 10

This comment has been minimized.

@selvanair

selvanair Apr 15, 2017

Contributor

The displayed font for username, password etc. and the text on buttons in all dialogs look tiny -- may be its my hi-res but small laptop screen coupled with the font used.

@selvanair

selvanair Apr 15, 2017

Contributor

The displayed font for username, password etc. and the text on buttons in all dialogs look tiny -- may be its my hi-res but small laptop screen coupled with the font used.

This comment has been minimized.

@Joungkyun

Joungkyun Apr 25, 2017

Contributor

As 4d97447, change the font name to the default font of Windows KR(Malgun Gothic) and increased font size to 9. And some fixed text positions. Plez check.

@Joungkyun

Joungkyun Apr 25, 2017

Contributor

As 4d97447, change the font name to the default font of Windows KR(Malgun Gothic) and increased font size to 9. And some fixed text positions. Plez check.

This comment has been minimized.

@Joungkyun

Joungkyun Apr 25, 2017

Contributor

login
config
config-proxy
config-detail
config-info
config-view-status

Show outdated Hide outdated res/openvpn-gui-res-kr.rc
IDS_ERR_MANY_CONFIGS "OpenVPN GUI는 %d config 이상의 설정은 지원하지 않습니다. 더이상 설정이 필요한 경우 개발자에게 연락 하십시오."
IDS_NFO_NO_CONFIGS "설정 파일이 없습니다.\n"\
"""파일 불러오기.."" 메뉴를 이용하거나 설정 파일을 ""%s"" 또는 ""%s""로 복사 하십시오."
IDS_ERR_CONFIG_NOT_AUTHORIZED "이 연결(%s)을 시작하기 위하여 ""%s"" 그룹 권한이 필요합니다. \"

This comment has been minimized.

@selvanair

selvanair Apr 15, 2017

Contributor

\" at the end of this line should be "\
Wonder why travis didn't catch this..

@selvanair

selvanair Apr 15, 2017

Contributor

\" at the end of this line should be "\
Wonder why travis didn't catch this..

This comment has been minimized.

@Joungkyun

Joungkyun Apr 16, 2017

Contributor

This problem was corrected to 8efb54a. please check.

@Joungkyun

Joungkyun Apr 16, 2017

Contributor

This problem was corrected to 8efb54a. please check.

Show outdated Hide outdated res/openvpn-gui-res-kr.rc
"이전의 인증 대화 상자를 완료 하십시오."
IDS_ERR_ADD_USER_TO_ADMIN_GROUP """%s"" group에 사용자 추가를 실패했습니다."
IDS_ERR_ONE_CONN_OLD_VER "OpenVPN 2.0-beta6 이전 버전에서는 2개 이상의 동시 연결을 지원하지 않습니다."
IDS_ERR_STOP_SERV_OLD_VER "You cannot use OpenVPN GUI to start a connection while the OpenVPN Service is running (with OpenVPN 1.5/1.6). Stop OpenVPN Service first if you want to use OpenVPN GUI."

This comment has been minimized.

@selvanair

selvanair Apr 15, 2017

Contributor

Missed or deliberately left out? There are a number of such below as well.
Not everything need to be translated in one attempt, so its perfectly fine if you want to leave these for some other time.

@selvanair

selvanair Apr 15, 2017

Contributor

Missed or deliberately left out? There are a number of such below as well.
Not everything need to be translated in one attempt, so its perfectly fine if you want to leave these for some other time.

This comment has been minimized.

@Joungkyun

Joungkyun Apr 16, 2017

Contributor

IDS_ERR_STOP_SERV_OLD_VER is duplicated. In 45bdd20, remove english message.

@Joungkyun

Joungkyun Apr 16, 2017

Contributor

IDS_ERR_STOP_SERV_OLD_VER is duplicated. In 45bdd20, remove english message.

@selvanair

This comment has been minimized.

Show comment
Hide comment
@selvanair

selvanair Apr 16, 2017

Contributor
Contributor

selvanair commented Apr 16, 2017

@chipitsine

This comment has been minimized.

Show comment
Hide comment
@chipitsine

chipitsine Apr 16, 2017

Contributor

people do not pay attention to warnings.
there was a "warning" on duplicate resources

727eaee

actually, it was a bug.

I couldn't find a way to turn those "warnings" into errors.

Contributor

chipitsine commented Apr 16, 2017

people do not pay attention to warnings.
there was a "warning" on duplicate resources

727eaee

actually, it was a bug.

I couldn't find a way to turn those "warnings" into errors.

@selvanair

This comment has been minimized.

Show comment
Hide comment
@selvanair

selvanair Apr 25, 2017

Contributor

Thanks for fixes. Now the font and size looks good for hangul text. The backslashes showing up as the symbol for Korean Won is normal I suppose -- is it possible to get it displayed as a normal backslash?

Let's wait a bit more and see if anyone can review the translations.

Contributor

selvanair commented Apr 25, 2017

Thanks for fixes. Now the font and size looks good for hangul text. The backslashes showing up as the symbol for Korean Won is normal I suppose -- is it possible to get it displayed as a normal backslash?

Let's wait a bit more and see if anyone can review the translations.

@Joungkyun

This comment has been minimized.

Show comment
Hide comment
@Joungkyun

Joungkyun Apr 25, 2017

Contributor

for displayed as normal backslash, we can change to the other fonts that displayed as normal backslash. However, it is not supported in Windows default fonts.

P.S.
I was the commiter of Mozilla L10n:ko, and I was the owner of thunderbird L10n:ko. I have been involved in translating Firefox 3.0 and Thunderbird 1.0 ~ 2.0. Currently, I'm registered as Alumni members on
https://wiki.mozilla.org/L10n:Teams:ko
. So translation quality will not be bad

mozilla-l10n-ko

Contributor

Joungkyun commented Apr 25, 2017

for displayed as normal backslash, we can change to the other fonts that displayed as normal backslash. However, it is not supported in Windows default fonts.

P.S.
I was the commiter of Mozilla L10n:ko, and I was the owner of thunderbird L10n:ko. I have been involved in translating Firefox 3.0 and Thunderbird 1.0 ~ 2.0. Currently, I'm registered as Alumni members on
https://wiki.mozilla.org/L10n:Teams:ko
. So translation quality will not be bad

mozilla-l10n-ko

@selvanair

This comment has been minimized.

Show comment
Hide comment
@selvanair

selvanair Apr 25, 2017

Contributor

Then leave the backslash as is -- most people are used to seeing it as "Won" I guess.

So translation quality will not be bad

I do not doubt it a bit.. We just have the policy of getting a review and ACK for all PRs as far as possible. If no review is forthcoming we'll lazy ACK this.

Again, thanks a lot for the translations --- this is a whole new language addition and a lot of work. Much appreciated.

Contributor

selvanair commented Apr 25, 2017

Then leave the backslash as is -- most people are used to seeing it as "Won" I guess.

So translation quality will not be bad

I do not doubt it a bit.. We just have the policy of getting a review and ACK for all PRs as far as possible. If no review is forthcoming we'll lazy ACK this.

Again, thanks a lot for the translations --- this is a whole new language addition and a lot of work. Much appreciated.

@Joungkyun

This comment has been minimized.

Show comment
Hide comment
@Joungkyun

Joungkyun Apr 25, 2017

Contributor

thank you, selvanair

Contributor

Joungkyun commented Apr 25, 2017

thank you, selvanair

@selvanair

This comment has been minimized.

Show comment
Hide comment
@selvanair

selvanair May 8, 2017

Contributor

I think we should get this merged.
@Joungkyun Could you please squash the commits into two (the font change may be kept as one commit and all the rest as one) and force push?

Contributor

selvanair commented May 8, 2017

I think we should get this merged.
@Joungkyun Could you please squash the commits into two (the font change may be kept as one commit and all the rest as one) and force push?

@Joungkyun

This comment has been minimized.

Show comment
Hide comment
@Joungkyun

Joungkyun May 10, 2017

Contributor

@selvanair Sorry, I am not familiar with git yet.

Contributor

Joungkyun commented May 10, 2017

@selvanair Sorry, I am not familiar with git yet.

@selvanair

This comment has been minimized.

Show comment
Hide comment
@selvanair

selvanair May 10, 2017

Contributor

@Joungkyun : I can squash and merge if its ok with you. It will look like this branch

Contributor

selvanair commented May 10, 2017

@Joungkyun : I can squash and merge if its ok with you. It will look like this branch

@Joungkyun

This comment has been minimized.

Show comment
Hide comment
@Joungkyun

Joungkyun May 10, 2017

Contributor

I rebased and I reduced my commit to 3 ea. The last commit (fixed typo) was left in a non-contiguous sequence with the first commit. Is this correct?

Contributor

Joungkyun commented May 10, 2017

I rebased and I reduced my commit to 3 ea. The last commit (fixed typo) was left in a non-contiguous sequence with the first commit. Is this correct?

@selvanair selvanair merged commit 06b2170 into OpenVPN:master May 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@selvanair

This comment has been minimized.

Show comment
Hide comment
@selvanair

selvanair May 10, 2017

Contributor

This looks good. Merging

Contributor

selvanair commented May 10, 2017

This looks good. Merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment