Permalink
Commits on Aug 9, 2018
  1. Clarify and expand management interface documentation

    jkbullard authored and cron2 committed Aug 8, 2018
    Clarify and expand the documentation for the management interface:
    
    * Add examples of static and dynamic challenge/response sequences in
    the "COMMAND -- password and username" section.
    
    * Expand the "Challenge/Response" section with more detail.
    
    * Use "management interface client" throughout (instead of "management
    client", which was used in several places previously).
    
    * Clarify when both a username and password are needed, not just a
    username or a password.
    
    * Clarify that an exit with a fatal error for a dynamic C/R will occur
    only if "--auth-retry none" (the default) is in effect.
    
    * Fix a typo. ("posesses" => "possesses").
    
    Signed-off-by: Jonathan K. Bullard <jkbullard@gmail.com>
    Acked-by: Selva Nair <selva.nair@gmail.com>
    Message-Id: <nEV9l80I3peitTd26qmQFpeoaQbEO-IR74B1gOvCLv-IfvQKjNfL9UnZq1aWr20480nGcbkSnhA-mSGEI5kG7JBMsGpNbNf2FExV3CSzRf4=@protonmail.com>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17390.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  2. Fix subnet topology on NetBSD.

    moubctez authored and cron2 committed Aug 2, 2018
    Signed-off-by: Adam Ciarcin?ski <adam@netbsd.org>
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <8110ED8B-4084-4D47-87E2-7B1C14041268@netbsd.org>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17399.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Aug 8, 2018
  1. Introduce buffer_write_file()

    syzzer authored and cron2 committed Aug 6, 2018
    Rewrite buf_write_string_file to buffer_write_file, which is simpler to
    use and can deal with not-null-terminated strings.  Mostly implemented so
    this can be easily reused for tls-crypt-v2 (client) key files.
    
    Signed-off-by: Steffan Karger <steffan.karger@fox-it.com>
    Acked-by: Antonio Quartulli <antonio@openvpn.net>
    Tested-by: Antonio Quartulli <antonio@openvpn.net>
    Message-Id: <1533542553-7383-1-git-send-email-steffan.karger@fox-it.com>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17371.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  2. Accept empty password and/or response in auth-pam plugin

    selvanair authored and cron2 committed Aug 8, 2018
    In the auth-pam plugin correctly parse the static challenge string
    even when password or challenge response is empty.
    
    Whether an empty user input is an error is determined by the PAM
    conversation function depending on whether the PAM module queries
    for it or not.
    
    Signed-off-by: Selva Nair <selva.nair@gmail.com>
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <1533696271-21799-2-git-send-email-selva.nair@gmail.com>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17382.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  3. Bump version of openvpn plugin argument structs to 5

    selvanair authored and cron2 committed Aug 8, 2018
    This was missed in commit 6690769
    that exported base64_encode and base64_decode() functions.
    
    Also check the version is >= 5 in auth-pam plugin to ensure
    that the base64_decode function pointer can be referenced.
    
    Signed-off-by: Selva Nair <selva.nair@gmail.com>
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <1533696271-21799-1-git-send-email-selva.nair@gmail.com>
    URL: https://www.mail-archive.com/search?l=mid&q=1533696271-21799-1-git-send-email-selva.nair@gmail.com
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Aug 7, 2018
  1. Parse static challenge response in auth-pam plugin

    selvanair authored and cron2 committed Jul 25, 2018
    If static challenge is in use, the password passed to the plugin by openvpn
    is of the form "SCRV1:base64-pass:base64-response". Parse this string to
    separate it into password and response and use them to respond to queries
    in the pam conversation function.
    
    On the plugin parameters line the substitution keyword for the static
    challenge response is "OTP". For example, for pam config named "test" that
    prompts for "user", "password" and "pin", use
    
    plugin openvpn-auth-pam.so "test user USERNAME password PASSWORD pin OTP"
    
    Signed-off-by: Selva Nair <selva.nair@gmail.com>
    
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <1532486093-24793-1-git-send-email-selva.nair@gmail.com>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17307.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Aug 5, 2018
  1. plugin: Export base64 encode and decode functions

    dsommers authored and cron2 committed May 5, 2017
    This patch builds on the "Export secure_memzero() to plug-ins" patch and
    adds export of openvpn_base64_encode() and openvpn_base64_decode()
    
    This also ships with a very simple plug-in which demonstrates how to use
    the new exported functions.
    
    Signed-off-by: David Sommerseth <davids@openvpn.net>
    Acked-by: Selva Nair <selva.nair@gmail.com>
    Message-Id: <20170505214624.11675-1-davids@openvpn.net>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg14558.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  2. Resolves small IV_GUI_VER typo in the documentation.

    jbekkema authored and cron2 committed Jul 23, 2018
    Acked-by: Arne Schwabe <arne@rfc2549.org>
    Message-Id: <429EB687-EB2D-4C67-B3EA-0A3BECA640B1@sparklabs.com>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17288.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  3. Correct the declaration of handle in 'struct openvpn_plugin_args_open…

    selvanair authored and cron2 committed Nov 21, 2017
    …_return'
    
    - This is an opaque pointer so the change should not affect
      existing plugins. But it makes the code consistent and clears up
      the documentation as the handle pointer is treated as of type
      "openvpn_plugin_handle_t" in the rest of the code.
    
    Signed-off-by: Selva Nair <selva.nair@gmail.com>
    Acked-by: Antonio Quartulli <antonio@openvpn.net>
    Message-Id: <1511228605-23207-1-git-send-email-selva.nair@gmail.com>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15908.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jul 24, 2018
  1. make tls-auth and tls-crypt per-connection-block options

    ordex authored and cron2 committed Jul 7, 2018
    Different VPN servers may use different tls-auth/crypt keys.
    For this reason it is convenient to make tls-auth/crypt
    per-connection-block options so that the user is allowed to
    specify one key per remote.
    
    If no tls-auth/crypt option is specified in a given connection
    block, the global settings, if any, are used.
    
    Trac: #720
    Cc: Steffan Karger <steffan@karger.me>
    Signed-off-by: Antonio Quartulli <a@unstable.cc>
    Acked-by: Steffan Karger <steffan.karger@fox-it.com>
    Message-Id: <20180707090421.25953-2-a@unstable.cc>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17226.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  2. crypto: always reload tls-auth/crypt key contexts

    ordex authored and cron2 committed Jul 8, 2018
    In preparation to having tls-auth/crypt keys per connection
    block, it is important to ensure that such material is always
    reloaded upon SIGUSR1, no matter if `persist-key` was specified
    or not.
    
    This is required because when moving from one remote to the
    other the key may change and thus the key context needs to
    be refreshed.
    
    To ensure that the `persist-key` logic will still work
    as expected, the tls-auth/crypt key is pre-loaded so that
    the keyfile is not required at runtime.
    
    Trac: #720
    Cc: Steffan Karger <steffan@karger.me>
    Signed-off-by: Antonio Quartulli <a@unstable.cc>
    Acked-by: Steffan Karger <steffan.karger@fox-it.com>
    Message-Id: <20180708024517.27108-1-a@unstable.cc>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17237.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jul 22, 2018
  1. Add crypto_pem_{encode,decode}()

    syzzer authored and cron2 committed Jul 22, 2018
    Needed for tls-crypt-v2, but isolated enough to be reviewed as a separate
    patch.
    
    The encode API allocates memory, because it fits our typical gc-oriented
    code pattern and the caller does not have to do multiple calls or
    calculations to determine the required destination buffer size.
    
    The decode API does not allocate memory, because the required destination
    buffer is always smaller than the input buffer (so is easy to manage by
    the caller) and does not force the caller to use the heap.
    
    Signed-off-by: Steffan Karger <steffan.karger@fox-it.com>
    Acked-by: Antonio Quartulli <antonio@openvpn.net>
    Message-Id: <20180722100645.5813-1-steffan@karger.me>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17284.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jul 18, 2018
  1. Remove unneeded newline in debug message in reliable.c

    Gert van Dijk authored and cron2 committed Jul 18, 2018
    Signed-off-by: Steffan Karger <steffan.karger@fox-it.com>
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <1531924073-29243-4-git-send-email-steffan.karger@fox-it.com>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17262.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  2. Make second parameter to reliable_send_purge() const

    Gert van Dijk authored and cron2 committed Jul 18, 2018
    Signed-off-by: Steffan Karger <steffan.karger@fox-it.com>
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <1531924073-29243-3-git-send-email-steffan.karger@fox-it.com>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17261.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  3. Minor reliability layer documentation fixes

    Gert van Dijk authored and cron2 committed Jul 18, 2018
    Signed-off-by: Steffan Karger <steffan.karger@fox-it.com>
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <1531924073-29243-2-git-send-email-steffan.karger@fox-it.com>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17260.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jul 13, 2018
  1. socket: make stream_buf_* functions static

    ordex authored and cron2 committed Jul 12, 2018
    stream_buf_init(), stream_buf_close() and stream_buf_added()
    are only used within socket.c, therefore there is noneed to
    have them declared in socket.h.
    
    Make them static and remove useless declarations.
    This change reuired adding function prototypes in socket.c to
    avoid useless code re-ordering.
    
    Signed-off-by: Antonio Quartulli <a@unstable.cc>
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <20180712012955.24050-1-a@unstable.cc>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17246.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  2. Print lzo_init() return code in case of errors

    cron2 committed Jul 13, 2018
    This can help pinpointing what exactly went wrong in case of
    init failures (library version mismatch, memory issues, ...)
    
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
    Acked-by: Arne Schwabe <arne@rfc2549.org>
    Message-Id: <20180713081951.31174-1-gert@greenie.muc.de>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17248.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jul 12, 2018
  1. Move execve/run_script helper functions to run_command.c

    syzzer authored and cron2 committed Jul 4, 2018
    To avoid having to include misc.c - which is a dependency mess - in the
    tls-crypt unit tests, move the command execution helper functions to a new
    run_command.c module.
    
    While at it, abstract away the script_security global variable.
    
    Signed-off-by: Steffan Karger <steffan.karger@fox-it.com>
    Acked-by: Antonio Quartulli <antonio@openvpn.net>
    Message-Id: <20180704175404.22371-2-steffan@karger.me>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17212.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jul 5, 2018
  1. Move file-related functions from misc.c to platform.c

    syzzer authored and cron2 committed Jul 4, 2018
    To avoid having to include misc.c - which is a dependency mess - in the
    tls-crypt unit tests, move file-handing related functions to platform.c
    (which is where other file-related functions already reside).
    
    Note that platform_create_temp_file() needs random.  To avoid including
    misc.c in other tests that use platform.c, add a mock get_random().
    
    (Almost every test includes platform.c, because buffer.c depends on it.
    That smells like it needs cleanup too, but not in this patch set.)
    
    Signed-off-by: Steffan Karger <steffan.karger@fox-it.com>
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <20180704175404.22371-1-steffan@karger.me>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17208.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jul 3, 2018
  1. Add MTU to Android IFCONFIG6 control command

    schwabe authored and cron2 committed Jul 3, 2018
    Since OpenVPN nows supports IPv6 only connections, OpenVPN for Android
    cannot longer rely on IFCONFIG to send the MTU. Add sending the MTU to
    IFCONFIG6 too.
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <20180703161751.7680-1-arne@rfc2549.org>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17186.html
    
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jul 2, 2018
  1. Extend push-remove to also handle 'ifconfig'.

    cron2 committed Jul 1, 2018
    Push-remove (introduced in commit 970312f) did not handle "ifconfig"
    yet, as both "ifconfig" and "ifconfig-ipv6" are handled differently from
    all other pushed options.  Since there was no valid use-case to not-push
    "ifconfig" (no support on the client side for running IPv6-only) this
    was not an issue so far - but with the recent commits to enable ipv6-only
    operation it can be a desirable feature.
    
    The implementation is similar to "push-remove ifconfig-ipv6" - namely,
    flagging via a new context option (c->options.push_ifconfig_ipv4_blocked)
    and then not creating the push statement in "send_push_reply()".
    
    While not truly elegant, it's much less invasive than the alternatives
    (storing the list of "push-remove" statements somewhere and then checking
    in push_option_ex())
    
    Trac: #1072
    
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
    
    Acked-by: Antonio Quartulli <antonio@openvpn.net>
    Message-Id: <20180701195938.2541-1-gert@greenie.muc.de>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17169.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jun 29, 2018
  1. openssl: add missing #include statements

    syzzer authored and cron2 committed Nov 26, 2017
    Compiling our current master against OpenSSL 1.1 with
    -DOPENSSL_API_COMPAT=0x10100000L screams bloody murder.  This patch fixes
    the errors caused by missing includes.  Previous openssl versions would
    usually include 'the rest of the world', but they're fixing that.  So we
    should no longer rely on it.
    
    (And sneaking in alphabetic ordering of the includes while touching them.)
    
    Signed-off-by: Steffan Karger <steffan@karger.me>
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <20171126154912.13283-1-steffan@karger.me>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15936.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  2. openssl: don't use deprecated SSLEAY/SSLeay symbols

    syzzer authored and cron2 committed Nov 26, 2017
    Compiling our current master against OpenSSL 1.1 with
    -DOPENSSL_API_COMPAT=0x10100000L screams bloody murder.  This patch fixes
    the errors about the deprecated SSLEAY/SSLeay symbols and defines.
    
    Signed-off-by: Steffan Karger <steffan@karger.me>
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <20171126150401.28565-1-steffan@karger.me>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15934.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jun 23, 2018
  1. Add %d, %u and %lu tests to test_argv unit tests.

    cron2 committed Jun 23, 2018
    Some basic integer tests to verify signed, unsigned and
    long unsigned (1L) printing.
    
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
    
    Acked-by: Selva Nair <selva.nair@gmail.com>
    Message-Id: <20180623191538.29317-1-gert@greenie.muc.de>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17131.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  2. windows: properly configure TAP driver when no IPv4 is configured

    ordex authored and cron2 committed Jun 23, 2018
    This patch ensures that the TAP driver on a windows host is still
    configured, even though no IPv4 has been provided.
    
    In this case the TAP driver ioctl will be invoked with a fake
    0.0.0.0/0.0.0.0 IPv4 which will simply start the interface and
    get it to a working state.
    
    Trac: #208
    Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <20180623183108.18684-1-a@unstable.cc>
    URL: https://www.mail-archive.com/search?l=mid&q=20180623183108.18684-1-a@unstable.cc
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  3. add support for %lu in argv_printf and prevent ASSERT

    ordex authored and cron2 committed Jun 23, 2018
    %lu is not supported by our tiny argv_printf implementation, therefore
    it will trigger an ASSERT() when parsing it at route.c:1638.
    
    Add support for '%lu' in argv_print() and prevent the ASSERT from being
    triggered.
    
    Signed-off-by: Antonio Quartulli <a@unstable.cc>
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <20180623021147.22792-1-a@unstable.cc>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17115.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  4. travis-ci: cleanup, refactor, upgrade ssl libraries

    chipitsine authored and cron2 committed May 27, 2018
    Both "compiler" and "exclude" are redundant, so remove them.
    Add openssl-1.0.1u to build matrix. Enable explicit apt update
    (it was disabled by default in travis-ci).
    
    Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com>
    
    --
    v2: Add openssl-1.0.1u to build matrix (thanks to Steffan Karger),
    Add explicit apt-get update (it was disabled by default in travis-ci)
    Acked-by: Steffan Karger <steffan.karger@fox-it.com>
    Message-Id: <20180527190057.3488-1-chipitsine@gmail.com>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg16898.html
    
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jun 18, 2018
  1. tun: ensure interface can be configured with IPv6 only

    ordex authored and cron2 committed Jun 18, 2018
    This change ensures that an interface is properly brought
    up and down even when only IPv6 settings are configured/pushed.
    
    At the same time, some code restyling took place to ensure the new
    generic logic is easier to read. Both do_ifconfig() and close_tun()
    (Linux only) functions have been rearranged by splitting the logic
    into a v4 and a v6 specific part. Each part has then been moved
    into an idependent helper that can be invoked as
    needed.
    
    This makes the code easier to read and more "symmetric" with
    respect to the two address families.
    
    Trac: #208
    Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
    
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <20180618074733.19773-1-a@unstable.cc>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17064.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jun 13, 2018
  1. tun: get rid of tt->did_ifconfig member

    ordex authored and cron2 committed Jun 13, 2018
    tt->did_ifconfig is currently only read by the Linux platform, but
    it is currently uselessly set also by every other system.
    
    The Linux platform does not actually even need this member and can
    directly rely on tt->did_ifconfig_setup.
    
    For the reasons above, remove the tt->did_ifconfig at all and use
    tt->did_ifconfig_setup where needed (close_tun() on Linux).
    
    Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
    
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <20180613122824.4207-4-a@unstable.cc>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17046.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  2. tun: always pass a valid tt pointer

    ordex authored and cron2 committed Jun 13, 2018
    This patch is a small "logic restyle" which basically moves the
    check for "tt != NULL" outside of the various close_tun()
    implementations and replaces it with an ASSERT.
    
    This way the check is done only once and the function can rely
    on the assumption that "tt" is always valid.
    
    This change is mainly to improve the code style inside close_tun()
    implementations by removing one level of indentation.
    
    No functional change is present.
    
    Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
    
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <20180613122824.4207-3-a@unstable.cc>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17045.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  3. tun: ensure gc and argv are properly handled

    ordex authored and cron2 committed Jun 13, 2018
    Everytime a argv object is initialized with argv_new(), it has
    to be released with argv_reset() once not needed anymore.
    
    Ensure this kind of objects are always properly released to avoid
    memory leaks.
    
    At the same time, remove those gc_arena objects that are initialized
    but never used/released.
    
    Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
    
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <20180613122824.4207-2-a@unstable.cc>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17044.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jun 9, 2018
  1. Add Interactive Service developer documentation

    rozmansi authored and cron2 committed Apr 19, 2018
    The OpenVPN Interactive Service documentation from
    https://community.openvpn.net/openvpn/wiki/OpenVPNInteractiveService was
    upgraded with a description of the client-service communication flow,
    service registry configuration, and non-default instance installation.
    
    Acked-by: Selva Nair <selva.nair@gmail.com>
    Message-Id: <20180419112313.1013-1-simon@rozman.si>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg16794.html
    
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jun 8, 2018
  1. Replace M_DEBUG with D_LOW as the former is too verbose

    selvanair authored and cron2 committed Jun 5, 2018
    M_DEBUG only indicates the type of the message and will print even
    at verb 0.  Use D_LOW which is M_DEBUG combined with verb = 4 and
    a mute level.
    
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <1528229170-6175-1-git-send-email-selva.nair@gmail.com>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg16964.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
  2. pool: convert pool 'type' to enum

    ordex authored and cron2 committed Jun 8, 2018
    The pool 'type' member is actually an enumered type, therefore
    declare it as 'enum' to improve static code analisys and
    readability.
    
    Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <20180608052017.6696-4-a@unstable.cc>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17000.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>
Commits on Jun 5, 2018
  1. pool: restyle ipv4/ipv6 members to improve readability

    ordex authored and cron2 committed Jun 5, 2018
    (This is only code refactoring)
    
    IPv4 and IPv6 members are all part of the same flat hierarchy
    in the pool data structure, without a proper name convention.
    
    Create 2 sub-structures to properly separate IPv4 from IPv6
    related members. This should make the structure more organized
    and also slightly improve code readability.
    
    Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
    Acked-by: Gert Doering <gert@greenie.muc.de>
    Message-Id: <20180605090421.9746-3-a@unstable.cc>
    URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg16944.html
    Signed-off-by: Gert Doering <gert@greenie.muc.de>