Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvidu-browser: double-asking consent when using OpenVidu.getUserMedia #330

Closed
mserve opened this issue Oct 4, 2019 · 3 comments
Closed

Comments

@mserve
Copy link
Contributor

mserve commented Oct 4, 2019

There is a double-consent request to the user when using OpenVidu.getUserMedia as eg in

var OV = new OpenVidu();
OV.getUserMedia({
    audioSource: false, // No audio source - not supported in screen share
    videoSource: 'screen', // The source of video. 
}).then( ... );

I guess there should be a return statement in https://github.com/OpenVidu/openvidu/blob/master/openvidu-browser/src/OpenVidu/OpenVidu.ts#L569 as getUserMedia() should not be called at all if the videoSource is screen and there is no audio

mserve added a commit to mserve/openvidu that referenced this issue Oct 4, 2019
@mserve
Copy link
Contributor Author

mserve commented Oct 4, 2019

See PR #331

@pabloFuente
Copy link
Member

See #331 (comment)

@pabloFuente
Copy link
Member

PR has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants