Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port - resource file handling utils #41

Closed
JarbasAl opened this issue Feb 2, 2022 · 2 comments
Closed

port - resource file handling utils #41

JarbasAl opened this issue Feb 2, 2022 · 2 comments
Labels
discussion do we want this? mk2 ported from mark2 mycroft-sync cherry pick from upstream

Comments

@JarbasAl
Copy link
Member

JarbasAl commented Feb 2, 2022

potential commit of interest in mark2/qa branch - MycroftAI@b9f814a
@JarbasAl JarbasAl added mk2 ported from mark2 discussion do we want this? mycroft-sync cherry pick from upstream labels Feb 2, 2022
@JarbasAl JarbasAl changed the title port - Move resource file location and translation logic into skill_data.py port - resource file handling utils Feb 2, 2022
@NeonDaniel
Copy link
Member

Looks interesting; translator raises some questions for me since Neon defines a translator to perform language translation, whereas the one defined here seems to just resolve the correct resource file

@JarbasAl
Copy link
Member Author

JarbasAl commented Jun 6, 2022

closed by #130 , but also needs #135 bugfix to be merged soon

@JarbasAl JarbasAl closed this as completed Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion do we want this? mk2 ported from mark2 mycroft-sync cherry pick from upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JarbasAl @NeonDaniel