Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure when no fallback stt set #84

Closed
builderjer opened this issue Mar 9, 2022 · 2 comments
Closed

Failure when no fallback stt set #84

builderjer opened this issue Mar 9, 2022 · 2 comments
Labels
bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core

Comments

@builderjer
Copy link

builderjer commented Mar 9, 2022

If there is no fallback_module, the mycroft-speech.service fails to load.

I believe it has something to do with this:

if not self.fallback_stt:
clazz = self.get_fallback_stt()
self.fallback_stt = clazz()

If it was changed to this:

    359  -   self.fallback_stt = clazz()
    359  +  if clazz:
    360  +      self.fallback_stt = clazz()

I think it may work

@JarbasAl
Copy link
Member

JarbasAl commented May 19, 2022

i believe this one has also been fixed by #91 , can you confirm @builderjer ?

@JarbasAl JarbasAl added bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core labels May 19, 2022
@builderjer
Copy link
Author

Yes, I have had no more issues here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug-ovos bug introdues in ovos-core, not present in mycroft-core
Projects
None yet
Development

No branches or pull requests

2 participants