Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/LF_unsupported_lang #125

Merged
merged 1 commit into from May 22, 2022

Conversation

NeonJarbas
Copy link

closes #123

@JarbasAl JarbasAl added the bug Something isn't working label May 22, 2022
@JarbasAl JarbasAl requested a review from NeonDaniel May 22, 2022 18:21
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #125 (7a6a6e7) into dev (6ceb058) will increase coverage by 2.93%.
The diff coverage is 34.78%.

@@            Coverage Diff             @@
##              dev     #125      +/-   ##
==========================================
+ Coverage   50.35%   53.28%   +2.93%     
==========================================
  Files         119      149      +30     
  Lines       10077     9073    -1004     
==========================================
- Hits         5074     4835     -239     
+ Misses       5003     4238     -765     
Impacted Files Coverage Δ
mycroft/api/__init__.py 30.24% <0.00%> (-47.99%) ⬇️
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6082802...7a6a6e7. Read the comment docs.

@JarbasAl JarbasAl merged commit 02abfa4 into OpenVoiceOS:dev May 22, 2022
4 of 5 checks passed
@NeonJarbas NeonJarbas deleted the fix/LF_unsupported_lang branch June 8, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported LF language prevents intent handling
2 participants